DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

ViewportOffset should dispatch creation in constructor. (#135420)

Browse Source
This commit is contained in:
Kostia Sokolovskyi 2023-09-29 23:08:39 +02:00 committed by GitHub
parent 9f4f6c4756
commit a11b21dba8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 54 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/flutter/lib/src/rendering/viewport_offset.dart
View File

@ -97,7 +97,11 @@ abstract class ViewportOffset extends ChangeNotifier {
/// Default constructor.
///
/// Allows subclasses to construct this object directly.
ViewportOffset();
ViewportOffset() {
if (kFlutterMemoryAllocationsEnabled) {
ChangeNotifier.maybeDispatchObjectCreation(this);
}
}
/// Creates a viewport offset with the given [pixels] value.
///

63
packages/flutter/test/widgets/two_dimensional_viewport_test.dart
View File

@ -1441,10 +1441,15 @@ void main() {
// Horizontal mismatch
expect(
() {
final ViewportOffset verticalOffset = ViewportOffset.fixed(0.0);
addTearDown(verticalOffset.dispose);
final ViewportOffset horizontalOffset = ViewportOffset.fixed(0.0);
addTearDown(horizontalOffset.dispose);
SimpleBuilderTableViewport(
verticalOffset: ViewportOffset.fixed(0.0),
verticalOffset: verticalOffset,
verticalAxisDirection: AxisDirection.left,
horizontalOffset: ViewportOffset.fixed(0.0),
horizontalOffset: horizontalOffset,
horizontalAxisDirection: AxisDirection.right,
delegate: builderDelegate,
mainAxis: Axis.vertical,
@ -1462,10 +1467,15 @@ void main() {
// Vertical mismatch
expect(
() {
final ViewportOffset verticalOffset = ViewportOffset.fixed(0.0);
addTearDown(verticalOffset.dispose);
final ViewportOffset horizontalOffset = ViewportOffset.fixed(0.0);
addTearDown(horizontalOffset.dispose);
SimpleBuilderTableViewport(
verticalOffset: ViewportOffset.fixed(0.0),
verticalOffset: verticalOffset,
verticalAxisDirection: AxisDirection.up,
horizontalOffset: ViewportOffset.fixed(0.0),
horizontalOffset: horizontalOffset,
horizontalAxisDirection: AxisDirection.down,
delegate: builderDelegate,
mainAxis: Axis.vertical,
@ -1483,10 +1493,15 @@ void main() {
// Both
expect(
() {
final ViewportOffset verticalOffset = ViewportOffset.fixed(0.0);
addTearDown(verticalOffset.dispose);
final ViewportOffset horizontalOffset = ViewportOffset.fixed(0.0);
addTearDown(horizontalOffset.dispose);
SimpleBuilderTableViewport(
verticalOffset: ViewportOffset.fixed(0.0),
verticalOffset: verticalOffset,
verticalAxisDirection: AxisDirection.left,
horizontalOffset: ViewportOffset.fixed(0.0),
horizontalOffset: horizontalOffset,
horizontalAxisDirection: AxisDirection.down,
delegate: builderDelegate,
mainAxis: Axis.vertical,
@ -1548,10 +1563,15 @@ void main() {
// Horizontal mismatch
expect(
() {
final ViewportOffset verticalOffset = ViewportOffset.fixed(0.0);
addTearDown(verticalOffset.dispose);
final ViewportOffset horizontalOffset = ViewportOffset.fixed(0.0);
addTearDown(horizontalOffset.dispose);
RenderSimpleBuilderTableViewport(
verticalOffset: ViewportOffset.fixed(0.0),
verticalOffset: verticalOffset,
verticalAxisDirection: AxisDirection.left,
horizontalOffset: ViewportOffset.fixed(0.0),
horizontalOffset: horizontalOffset,
horizontalAxisDirection: AxisDirection.right,
delegate: builderDelegate,
mainAxis: Axis.vertical,
@ -1570,10 +1590,15 @@ void main() {
// Vertical mismatch
expect(
() {
final ViewportOffset verticalOffset = ViewportOffset.fixed(0.0);
addTearDown(verticalOffset.dispose);
final ViewportOffset horizontalOffset = ViewportOffset.fixed(0.0);
addTearDown(horizontalOffset.dispose);
RenderSimpleBuilderTableViewport(
verticalOffset: ViewportOffset.fixed(0.0),
verticalOffset: verticalOffset,
verticalAxisDirection: AxisDirection.up,
horizontalOffset: ViewportOffset.fixed(0.0),
horizontalOffset: horizontalOffset,
horizontalAxisDirection: AxisDirection.down,
delegate: builderDelegate,
mainAxis: Axis.vertical,
@ -1592,10 +1617,15 @@ void main() {
// Both
expect(
() {
final ViewportOffset verticalOffset = ViewportOffset.fixed(0.0);
addTearDown(verticalOffset.dispose);
final ViewportOffset horizontalOffset = ViewportOffset.fixed(0.0);
addTearDown(horizontalOffset.dispose);
RenderSimpleBuilderTableViewport(
verticalOffset: ViewportOffset.fixed(0.0),
verticalOffset: verticalOffset,
verticalAxisDirection: AxisDirection.left,
horizontalOffset: ViewportOffset.fixed(0.0),
horizontalOffset: horizontalOffset,
horizontalAxisDirection: AxisDirection.down,
delegate: builderDelegate,
mainAxis: Axis.vertical,
@ -1622,10 +1652,15 @@ void main() {
}
);
addTearDown(delegate.dispose);
final ViewportOffset verticalOffset = ViewportOffset.fixed(10.0);
addTearDown(verticalOffset.dispose);
final ViewportOffset horizontalOffset = ViewportOffset.fixed(20.0);
addTearDown(horizontalOffset.dispose);
final RenderSimpleBuilderTableViewport renderViewport = RenderSimpleBuilderTableViewport(
verticalOffset: ViewportOffset.fixed(10.0),
verticalOffset: verticalOffset,
verticalAxisDirection: AxisDirection.down,
horizontalOffset: ViewportOffset.fixed(20.0),
horizontalOffset: horizontalOffset,
horizontalAxisDirection: AxisDirection.right,
delegate: delegate,
mainAxis: Axis.vertical,