From a11ac35035bbf8a5cc1ba4a0ad25deeff3b708c8 Mon Sep 17 00:00:00 2001
From: godofredoc <godofredoc@google.com>
Date: Thu, 1 Jun 2023 16:48:20 -0700
Subject: [PATCH] Do not retry lint or clang tidy tests. (flutter/engine#42498)

Retries on lints and clang tidy were hiding the issues as timeouts rather than providing the fail signal right away.

Bug: https://github.com/flutter/flutter/issues/128083

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
---
 engine/src/flutter/ci/builders/linux_clang_tidy.json         | 2 ++
 engine/src/flutter/ci/builders/mac_clang_tidy.json           | 2 ++
 engine/src/flutter/ci/builders/standalone/linux_license.json | 1 +
 3 files changed, 5 insertions(+)

diff --git a/engine/src/flutter/ci/builders/linux_clang_tidy.json b/engine/src/flutter/ci/builders/linux_clang_tidy.json
index 89893d7f474..2bc3ce148a9 100644
--- a/engine/src/flutter/ci/builders/linux_clang_tidy.json
+++ b/engine/src/flutter/ci/builders/linux_clang_tidy.json
@@ -61,6 +61,7 @@
                         "--shard-id=1",
                         "--shard-variants=android_debug_arm64"
                     ],
+		    "max_attempts": 1,
                     "script": "flutter/ci/lint.sh"
                 }
             ]
@@ -86,6 +87,7 @@
                         "--shard-id=0",
                         "--shard-variants=host_debug"
                     ],
+		    "max_attempts": 1,
                     "script": "flutter/ci/lint.sh"
                 }
             ]
diff --git a/engine/src/flutter/ci/builders/mac_clang_tidy.json b/engine/src/flutter/ci/builders/mac_clang_tidy.json
index 9a710376ac8..e0f0b73a34c 100644
--- a/engine/src/flutter/ci/builders/mac_clang_tidy.json
+++ b/engine/src/flutter/ci/builders/mac_clang_tidy.json
@@ -70,6 +70,7 @@
                         "--shard-id=1",
                         "--shard-variants=ios_debug_sim"
                     ],
+		    "max_attempts": 1,
                     "script": "flutter/ci/lint.sh"
                 }
             ]
@@ -99,6 +100,7 @@
                         "--shard-id=0",
                         "--shard-variants=host_debug"
                     ],
+		    "max_attempts": 1,
                     "script": "flutter/ci/lint.sh"
                 }
             ]
diff --git a/engine/src/flutter/ci/builders/standalone/linux_license.json b/engine/src/flutter/ci/builders/standalone/linux_license.json
index 95504a1ac20..15a792c79b8 100644
--- a/engine/src/flutter/ci/builders/standalone/linux_license.json
+++ b/engine/src/flutter/ci/builders/standalone/linux_license.json
@@ -11,6 +11,7 @@
     "tests": [
         {
             "name": "licenses check",
+	    "max_attempts": 1,
             "script": "flutter/ci/licenses.sh"
         }
     ]