From 9ef075582e0dcaa4df990338b931219465ffcbce Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Thu, 10 Sep 2020 13:21:17 -0700 Subject: [PATCH] Disable a flaky Scenarios test (flutter/engine#21075) This disables the macOS Scenarios app test testFlutterViewControllerDetachingSendsApplicationLifecycle until a fix for the flakiness is found. Related issue: https://github.com/flutter/flutter/issues/61620 --- .../ios/Scenarios/ScenariosTests/AppLifecycleTests.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m b/engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m index b2bf497cf36..3efa1741312 100644 --- a/engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m +++ b/engine/src/flutter/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m @@ -227,7 +227,9 @@ FLUTTER_ASSERT_ARC [engine setViewController:nil]; } -- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle { +// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness +// has been identified. https://github.com/flutter/flutter/issues/61620 +- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle { XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"]; // Let the engine finish booting (at the end of which the channels are properly set-up) before