From 9d7bdb5903bc7149b415bf268fa3c6413355e7ad Mon Sep 17 00:00:00 2001 From: Yuqian Li Date: Mon, 28 Sep 2020 22:46:21 -0700 Subject: [PATCH] Default FittedBox's clipBehavior to none (#66700) This is a continuation of https://github.com/flutter/flutter/pull/61366 after cl/333620714 See also https://flutter.dev/go/clip-behavior --- packages/flutter/lib/src/widgets/basic.dart | 4 ++-- packages/flutter/test/widgets/fitted_box_test.dart | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/flutter/lib/src/widgets/basic.dart b/packages/flutter/lib/src/widgets/basic.dart index ec8c3f87a7d..3c8a7a05736 100644 --- a/packages/flutter/lib/src/widgets/basic.dart +++ b/packages/flutter/lib/src/widgets/basic.dart @@ -1424,7 +1424,7 @@ class FittedBox extends SingleChildRenderObjectWidget { Key? key, this.fit = BoxFit.contain, this.alignment = Alignment.center, - this.clipBehavior = Clip.hardEdge, + this.clipBehavior = Clip.none, Widget? child, }) : assert(fit != null), assert(alignment != null), @@ -1452,7 +1452,7 @@ class FittedBox extends SingleChildRenderObjectWidget { /// {@macro flutter.widgets.Clip} /// - /// Defaults to [Clip.hardEdge]. + /// Defaults to [Clip.none]. final Clip clipBehavior; @override diff --git a/packages/flutter/test/widgets/fitted_box_test.dart b/packages/flutter/test/widgets/fitted_box_test.dart index 476d5be9b6a..92fe6d099bb 100644 --- a/packages/flutter/test/widgets/fitted_box_test.dart +++ b/packages/flutter/test/widgets/fitted_box_test.dart @@ -481,7 +481,7 @@ void main() { testWidgets('Can set and update clipBehavior', (WidgetTester tester) async { await tester.pumpWidget(FittedBox(fit: BoxFit.none, child: Container())); final RenderFittedBox renderObject = tester.allRenderObjects.whereType().first; - expect(renderObject.clipBehavior, equals(Clip.hardEdge)); + expect(renderObject.clipBehavior, equals(Clip.none)); await tester.pumpWidget(FittedBox(fit: BoxFit.none, child: Container(), clipBehavior: Clip.antiAlias)); expect(renderObject.clipBehavior, equals(Clip.antiAlias));