From 9d1b1df6f33ea54a4eaff15ae29277241e57855a Mon Sep 17 00:00:00 2001 From: Hixie Date: Thu, 17 Mar 2016 17:26:34 -0700 Subject: [PATCH] Fix position of the overlay Now that the overlay actually respects the position we give it, put it somewhere where the keyboard won't overlap it. --- packages/flutter/lib/src/rendering/performance_overlay.dart | 6 +++--- packages/flutter/lib/src/widgets/app.dart | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/flutter/lib/src/rendering/performance_overlay.dart b/packages/flutter/lib/src/rendering/performance_overlay.dart index b70d3711575..318e76328d2 100644 --- a/packages/flutter/lib/src/rendering/performance_overlay.dart +++ b/packages/flutter/lib/src/rendering/performance_overlay.dart @@ -83,14 +83,14 @@ class RenderPerformanceOverlay extends RenderBox { } double get intrinsicHeight { - const double kGraphHeight = 80.0; // must match value in performance_overlay_layer.cc + const double kDefaultGraphHeight = 80.0; double result = 0.0; if ((optionsMask | (1 << PerformanceOverlayOption.displayRasterizerStatistics.index) > 0) || (optionsMask | (1 << PerformanceOverlayOption.visualizeRasterizerStatistics.index) > 0)) - result += kGraphHeight; + result += kDefaultGraphHeight; if ((optionsMask | (1 << PerformanceOverlayOption.displayEngineStatistics.index) > 0) || (optionsMask | (1 << PerformanceOverlayOption.visualizeEngineStatistics.index) > 0)) - result += kGraphHeight; + result += kDefaultGraphHeight; return result; } diff --git a/packages/flutter/lib/src/widgets/app.dart b/packages/flutter/lib/src/widgets/app.dart index 9b280d17c8f..f89e8e90f2f 100644 --- a/packages/flutter/lib/src/widgets/app.dart +++ b/packages/flutter/lib/src/widgets/app.dart @@ -202,7 +202,7 @@ class WidgetsAppState extends State implements BindingO result = new Stack( children: [ result, - new Positioned(bottom: 0.0, left: 0.0, right: 0.0, child: new PerformanceOverlay.allEnabled()), + new Positioned(top: 0.0, left: 0.0, right: 0.0, child: new PerformanceOverlay.allEnabled()), ] ); }