DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

skyanalyzer cleanup

Browse Source 
Remove skyanalyzer filters for strong-mode hints that are gone now anyway.
This commit is contained in:
Hixie 2015-11-05 14:44:09 -08:00
parent 6fce298ea2
commit 9949143fbe
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
engine/src/flutter/sky/tools/skyanalyzer
View File

@ -36,14 +36,9 @@ _IGNORED_PATTERNS = [
re.compile(r'^\[(warning|hint)\] .+ will need runtime check to cast to type .+'), # https://github.com/dart-lang/sdk/issues/24542
re.compile(r'^\[error\] Type check failed: .*\(dynamic\) is not of type'), # allow unchecked casts from dynamic
# String mode hints. Those are going away anyway, but these in particular aren't useful.
re.compile(r'^\[hint\] .+ requires dynamic invoke'), # too many false positives, e.g. https://github.com/dart-lang/sdk/issues/24564
re.compile(r'^\[hint\] Runtime check on non-ground type .+ may throw StrongModeError'), # https://github.com/dart-lang/sdk/issues/24565
re.compile(r'^\[hint] \([_, ]+\) .+ has inferred type '), # ignore underscore-only arguments
# Bogus hint - https://github.com/dart-lang/sdk/issues/24710
re.compile(r'^\[hint\] \(toText == toPlainText\) \? toStyledText : toPlainText has inferred type \(String, String\) → Widget \(.+styled_text.dart,.+\)'),
re.compile(r'^\[hint\] .+ [?:] \([_, ]+\) .+ has inferred type .+'), #
re.compile(r'^\[hint\] .+ [?:] \([_, ]+\) .+ has inferred type .+'),
# Disable the lint checks that will be caught by code review
re.compile(r'^\[lint\] Avoid defining a one-member abstract class when a simple function will do'),