From 99023f06862c2e1fdc21cbd548e31e4a189bb299 Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Thu, 25 Mar 2021 13:02:12 -0700 Subject: [PATCH] Fix missed ignores (#79071) --- packages/flutter/lib/src/painting/notched_shapes.dart | 8 ++++---- packages/flutter/test/widgets/shortcuts_test.dart | 3 --- packages/flutter_tools/lib/src/base/command_help.dart | 2 -- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/packages/flutter/lib/src/painting/notched_shapes.dart b/packages/flutter/lib/src/painting/notched_shapes.dart index d92659a6a41..3f17c7f76e0 100644 --- a/packages/flutter/lib/src/painting/notched_shapes.dart +++ b/packages/flutter/lib/src/painting/notched_shapes.dart @@ -151,10 +151,10 @@ class AutomaticNotchedShape extends NotchedShape { final ShapeBorder? guest; @override - Path getOuterPath(Rect hostRect, Rect? guestRect) { // ignore: avoid_renaming_method_parameters, the - // parameters are renamed over the baseclass because they would clash - // with properties of this object, and the use of all four of them in - // the code below is really confusing if they have the same names. + Path getOuterPath(Rect hostRect, Rect? guestRect) { // ignore: avoid_renaming_method_parameters + // The parameters of this method are renamed over the baseclass because they + // would clash with properties of this object, and the use of all four of + // them in the code below is really confusing if they have the same names. final Path hostPath = host.getOuterPath(hostRect); if (guest != null && guestRect != null) { final Path guestPath = guest!.getOuterPath(guestRect); diff --git a/packages/flutter/test/widgets/shortcuts_test.dart b/packages/flutter/test/widgets/shortcuts_test.dart index fbd7a32d758..8a4eb859c7e 100644 --- a/packages/flutter/test/widgets/shortcuts_test.dart +++ b/packages/flutter/test/widgets/shortcuts_test.dart @@ -68,7 +68,6 @@ void main() { LogicalKeyboardKey.keyC, LogicalKeyboardKey.keyD, ); - // ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026 final LogicalKeySet setFromSet = LogicalKeySet.fromSet({ LogicalKeyboardKey.keyA, LogicalKeyboardKey.keyB, @@ -124,7 +123,6 @@ void main() { LogicalKeyboardKey.keyB, LogicalKeyboardKey.keyA, ); - // ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026 final LogicalKeySet set4 = LogicalKeySet.fromSet({ LogicalKeyboardKey.keyD, LogicalKeyboardKey.keyC, @@ -140,7 +138,6 @@ void main() { expect(map.containsKey(LogicalKeySet(LogicalKeyboardKey.keyA)), isTrue); expect( set2, - // ignore: prefer_const_literals_to_create_immutables, https://github.com/dart-lang/linter/issues/2026 equals(LogicalKeySet.fromSet({ LogicalKeyboardKey.keyA, LogicalKeyboardKey.keyB, diff --git a/packages/flutter_tools/lib/src/base/command_help.dart b/packages/flutter_tools/lib/src/base/command_help.dart index 4262c95f95b..7adabf7437e 100644 --- a/packages/flutter_tools/lib/src/base/command_help.dart +++ b/packages/flutter_tools/lib/src/base/command_help.dart @@ -8,8 +8,6 @@ import 'logger.dart'; import 'platform.dart'; import 'terminal.dart'; -// ignore_for_file: non_constant_identifier_names - const String fire = '🔥'; const String image = '🖼️'; const int maxLineWidth = 84;