From 98077617bbb07115b11da0ce1acea64d6ff63809 Mon Sep 17 00:00:00 2001 From: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> Date: Sat, 19 Nov 2022 03:38:10 +0800 Subject: [PATCH] Tiny improvement of RouteSettings display (#114481) * impl * Update packages/flutter/lib/src/widgets/navigator.dart Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> * Update navigator_test.dart Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> --- packages/flutter/lib/src/widgets/navigator.dart | 2 +- packages/flutter/test/widgets/navigator_test.dart | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/flutter/lib/src/widgets/navigator.dart b/packages/flutter/lib/src/widgets/navigator.dart index 7c13750892e..7541dca67ac 100644 --- a/packages/flutter/lib/src/widgets/navigator.dart +++ b/packages/flutter/lib/src/widgets/navigator.dart @@ -548,7 +548,7 @@ class RouteSettings { final Object? arguments; @override - String toString() => '${objectRuntimeType(this, 'RouteSettings')}("$name", $arguments)'; + String toString() => '${objectRuntimeType(this, 'RouteSettings')}(${name == null ? 'none' : '"$name"'}, $arguments)'; } /// Describes the configuration of a [Route]. diff --git a/packages/flutter/test/widgets/navigator_test.dart b/packages/flutter/test/widgets/navigator_test.dart index bedf08595f8..ba60f56871d 100644 --- a/packages/flutter/test/widgets/navigator_test.dart +++ b/packages/flutter/test/widgets/navigator_test.dart @@ -3935,6 +3935,16 @@ void main() { ); expect(policy, isA()); }); + + group('RouteSettings.toString', () { + test('when name is not null, should have double quote', () { + expect(const RouteSettings(name: '/home').toString(), 'RouteSettings("/home", null)'); + }); + + test('when name is null, should not have double quote', () { + expect(const RouteSettings().toString(), 'RouteSettings(none, null)'); + }); + }); } typedef AnnouncementCallBack = void Function(Route?);