From 96eb53d4ef63810df2067c9296ad337efe3db1e1 Mon Sep 17 00:00:00 2001 From: Rafael Weinstein Date: Fri, 21 Nov 2014 15:16:58 -0800 Subject: [PATCH] setChildrenInline wasn't doing anything and childrenInlien always deferred to isRenderParagraph. Also, add a test from the original webkit patch that called setChildrenInline in layoutBlock R=ojan@chromium.org Review URL: https://codereview.chromium.org/748943002 --- .../delete_block_contents-expected.txt | 5 ++++ .../tests/editing/delete_block_contents.sky | 28 +++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 engine/src/flutter/tests/editing/delete_block_contents-expected.txt create mode 100644 engine/src/flutter/tests/editing/delete_block_contents.sky diff --git a/engine/src/flutter/tests/editing/delete_block_contents-expected.txt b/engine/src/flutter/tests/editing/delete_block_contents-expected.txt new file mode 100644 index 00000000000..4cb8c8239fc --- /dev/null +++ b/engine/src/flutter/tests/editing/delete_block_contents-expected.txt @@ -0,0 +1,5 @@ +Running 1 tests +ok 1 height of an editable block remains the same after adding block elements and removing them +1 tests +1 pass +0 fail diff --git a/engine/src/flutter/tests/editing/delete_block_contents.sky b/engine/src/flutter/tests/editing/delete_block_contents.sky new file mode 100644 index 00000000000..833bcc0f878 --- /dev/null +++ b/engine/src/flutter/tests/editing/delete_block_contents.sky @@ -0,0 +1,28 @@ + + + +This test verifies that the height of an editable block remains the same after adding block elements and removing them. +
+ +