[fidl][flutter_runner] Port Migrate to new fit::optional compatible APIs (flutter/engine#11636)

* [fidl][flutter_runner] Port Migrate to new fit::optional compatible APIs

Updated all call-sites.

See: https://fuchsia-review.googlesource.com/c/fuchsia/+/304389

FIDL-564 #comment

Change-Id: I831712ffd4a47b8fc9cf1fe237b709a1b983109f

* fix observatory port and re-sync cmx files
This commit is contained in:
Kaushik Iska 2019-08-28 12:31:07 -07:00 committed by GitHub
parent 1a646c18bb
commit 9669b8fa01
7 changed files with 33 additions and 15 deletions

View File

@ -92,8 +92,8 @@ Application::Application(
// LaunchInfo::arguments optional.
if (auto& arguments = launch_info.arguments) {
settings_ = flutter::SettingsFromCommandLine(
fml::CommandLineFromIterators(arguments->begin(), arguments->end()));
settings_ = flutter::SettingsFromCommandLine(fml::CommandLineFromIterators(
arguments.value().begin(), arguments.value().end()));
}
// Determine /pkg/data directory from StartupInfo.
@ -257,6 +257,9 @@ Application::Application(
settings_.enable_observatory = false;
#else
settings_.enable_observatory = true;
// TODO(cbracken): pass this in as a param to allow 0.0.0.0, ::1, etc.
settings_.observatory_host = "127.0.0.1";
#endif
settings_.icu_data_path = "";

View File

@ -5,14 +5,17 @@
"sandbox": {
"features": [
"root-ssl-certificates",
"vulkan",
"deprecated-ambient-replace-as-executable"
"deprecated-ambient-replace-as-executable",
"vulkan"
],
"services": [
"fuchsia.crash.Analyzer",
"fuchsia.accessibility.SettingsManager",
"fuchsia.accessibility.semantics.SemanticsManager",
"fuchsia.device.NameProvider",
"fuchsia.feedback.CrashReporter",
"fuchsia.fonts.Provider",
"fuchsia.net.NameLookup",
"fuchsia.posix.socket.Provider",
"fuchsia.net.NameLookup",
"fuchsia.sysmem.Allocator",
"fuchsia.timezone.Timezone",
"fuchsia.tracing.provider.Registry",

View File

@ -5,14 +5,17 @@
"sandbox": {
"features": [
"root-ssl-certificates",
"vulkan",
"deprecated-ambient-replace-as-executable"
"deprecated-ambient-replace-as-executable",
"vulkan"
],
"services": [
"fuchsia.crash.Analyzer",
"fuchsia.accessibility.SettingsManager",
"fuchsia.accessibility.semantics.SemanticsManager",
"fuchsia.device.NameProvider",
"fuchsia.feedback.CrashReporter",
"fuchsia.fonts.Provider",
"fuchsia.net.NameLookup",
"fuchsia.posix.socket.Provider",
"fuchsia.net.NameLookup",
"fuchsia.sysmem.Allocator",
"fuchsia.timezone.Timezone",
"fuchsia.tracing.provider.Registry",

View File

@ -9,10 +9,13 @@
"deprecated-ambient-replace-as-executable"
],
"services": [
"fuchsia.crash.Analyzer",
"fuchsia.accessibility.SettingsManager",
"fuchsia.accessibility.semantics.SemanticsManager",
"fuchsia.device.NameProvider",
"fuchsia.feedback.CrashReporter",
"fuchsia.fonts.Provider",
"fuchsia.net.NameLookup",
"fuchsia.posix.socket.Provider",
"fuchsia.net.NameLookup",
"fuchsia.sysmem.Allocator",
"fuchsia.timezone.Timezone",
"fuchsia.tracing.provider.Registry",

View File

@ -9,10 +9,13 @@
"deprecated-ambient-replace-as-executable"
],
"services": [
"fuchsia.crash.Analyzer",
"fuchsia.accessibility.SettingsManager",
"fuchsia.accessibility.semantics.SemanticsManager",
"fuchsia.device.NameProvider",
"fuchsia.feedback.CrashReporter",
"fuchsia.fonts.Provider",
"fuchsia.net.NameLookup",
"fuchsia.posix.socket.Provider",
"fuchsia.net.NameLookup",
"fuchsia.sysmem.Allocator",
"fuchsia.timezone.Timezone",
"fuchsia.tracing.provider.Registry",

View File

@ -4,9 +4,12 @@
},
"sandbox": {
"features": [
"vulkan",
"deprecated-ambient-replace-as-executable"
],
"services": [
"fuchsia.accessibility.SettingsManager",
"fuchsia.accessibility.semantics.SemanticsManager",
"fuchsia.sys.Launcher"
]
}

View File

@ -627,7 +627,7 @@ void PlatformView::HandleFlutterPlatformChannelPlatformMessage(
writer.StartArray();
writer.StartObject();
writer.Key("text");
writer.String(text.get());
writer.String(text.value_or(""));
writer.EndObject();
writer.EndArray();
std::string result = json_buffer.GetString();