From 93d9a4e1edf4ce4f6dd3ff8a4d9dd0741123e7b4 Mon Sep 17 00:00:00 2001 From: "auto-submit[bot]" <98614782+auto-submit[bot]@users.noreply.github.com> Date: Wed, 9 Oct 2024 21:18:46 +0000 Subject: [PATCH] Reverts "Run gen_snapshot under /usr/bin/time (#55777)" (flutter/engine#55787) Reverts: flutter/engine#55777 Initiated by: matanlurey Reason for reverting: Breaks CI postsubmit (https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/485517/overview). Original PR Author: aam Reviewed By: {matanlurey} This change reverts the following previous change: This should help further troubleshoot https://github.com/flutter/flutter/issues/154437 --- DEPS | 2 +- engine/src/flutter/lib/snapshot/BUILD.gn | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/DEPS b/DEPS index 15e6f7c72ca..07f331794cb 100644 --- a/DEPS +++ b/DEPS @@ -277,7 +277,7 @@ allowed_hosts = [ ] deps = { - 'src': 'https://github.com/flutter/buildroot.git' + '@' + '773652167dbd506c5fb85d168e2c9038f24fed2a', + 'src': 'https://github.com/flutter/buildroot.git' + '@' + 'f85c3be4bf808add6ba867b8ff7943fd235b7b5e', 'src/flutter/third_party/depot_tools': Var('chromium_git') + '/chromium/tools/depot_tools.git' + '@' + '580b4ff3f5cd0dcaa2eacda28cefe0f45320e8f7', diff --git a/engine/src/flutter/lib/snapshot/BUILD.gn b/engine/src/flutter/lib/snapshot/BUILD.gn index 6c6ce7fce57..73611e45063 100644 --- a/engine/src/flutter/lib/snapshot/BUILD.gn +++ b/engine/src/flutter/lib/snapshot/BUILD.gn @@ -63,9 +63,6 @@ group("generate_snapshot_bins") { # See: `bin_to_linkable` rules below that build these outputs into linkable form # See: https://github.com/flutter/flutter/wiki/Flutter-engine-operation-in-AOT-Mode compiled_action("generate_snapshot_bin") { - # TODO(https://github.com/flutter/flutter/issues/154437). - prefix_with_time_cmd = true - if (target_cpu == "x86" && host_os == "linux") { # By default Dart will create a 32-bit gen_snapshot host binary if the target # platform is 32-bit. Override this to create a 64-bit gen_snapshot for x86