Keyboard type update (#164274)

This fixes the bug #163013 by detecting changes of the `keyboardType`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
René Kilczan 2025-03-12 22:02:48 +01:00 committed by GitHub
parent 03f1208721
commit 90d6f19d9a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 46 additions and 1 deletions

View File

@ -3266,7 +3266,8 @@ class EditableTextState extends State<EditableText>
}
if (_hasInputConnection) {
if (oldWidget.obscureText != widget.obscureText) {
if (oldWidget.obscureText != widget.obscureText ||
oldWidget.keyboardType != widget.keyboardType) {
_textInputConnection!.updateConfig(_effectiveAutofillClient.textInputConfiguration);
}
}

View File

@ -3093,6 +3093,50 @@ void main() {
expect(tester.testTextInput.setClientArgs!['obscureText'], isFalse);
});
testWidgets('Sends "updateConfig" when keyboardType is changed', (WidgetTester tester) async {
TextInputType keyboardType = TextInputType.text;
late StateSetter setState;
controller.text = 'Lorem';
await tester.pumpWidget(
MaterialApp(
home: StatefulBuilder(
builder: (BuildContext context, StateSetter stateSetter) {
setState = stateSetter;
return EditableText(
keyboardType: keyboardType,
controller: controller,
backgroundCursorColor: Colors.grey,
focusNode: focusNode,
style: textStyle,
cursorColor: cursorColor,
);
},
),
),
);
// Interact with the field to establish the input connection.
final Offset topLeft = tester.getTopLeft(find.byType(EditableText));
await tester.tapAt(topLeft + const Offset(0.0, 5.0));
await tester.pump();
expect(
(tester.testTextInput.setClientArgs!['inputType'] as Map<dynamic, dynamic>)['name'],
'TextInputType.text',
);
setState(() {
keyboardType = TextInputType.number;
});
await tester.pump();
expect(
(tester.testTextInput.setClientArgs!['inputType'] as Map<dynamic, dynamic>)['name'],
'TextInputType.number',
);
});
testWidgets('Sends viewId and updates config when it changes', (WidgetTester tester) async {
int viewId = 14;
late StateSetter setState;