From 8ff6f25fc17e572fbe9be8b57ddcdc43ecb3d40f Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Fri, 8 Feb 2019 14:30:16 -0800 Subject: [PATCH] Add flutter config to macOS targets (flutter/engine#7756) In c3ad553 (#7642), //shell/platform/darwin:framework_shared was added without the root flutter config, causing a build breakage in Fuchsia, where flutter sits under //third_party/flutter as opposed to at the root. The flutter root config is required to set -I../../third_party as an include path. --- engine/src/flutter/shell/platform/darwin/BUILD.gn | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/engine/src/flutter/shell/platform/darwin/BUILD.gn b/engine/src/flutter/shell/platform/darwin/BUILD.gn index 32315607454..672ea4537ed 100644 --- a/engine/src/flutter/shell/platform/darwin/BUILD.gn +++ b/engine/src/flutter/shell/platform/darwin/BUILD.gn @@ -61,6 +61,8 @@ source_set("framework_shared") { set_sources_assignment_filter(sources_assignment_filter) defines = [ "FLUTTER_FRAMEWORK" ] + + public_configs = [ "$flutter_root:config" ] } executable("flutter_channels_unittests") { @@ -78,4 +80,6 @@ executable("flutter_channels_unittests") { "$flutter_root/testing", "//third_party/dart/runtime:libdart_jit", ] + + public_configs = [ "$flutter_root:config" ] }