DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

remove FrameTiming named constructor (#20380)

Browse Source
This commit is contained in:
Ming Lyu (CareF) 2020-08-10 15:21:03 -04:00 committed by GitHub
parent 9bc3fe9f0c
commit 8b72bbcec9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/ui/window.dart
View File

@ -117,30 +117,6 @@ class FrameTiming {
FrameTiming._(List<int> timestamps)
: assert(timestamps.length == FramePhase.values.length), _timestamps = timestamps;
/// Construct [FrameTiming] with given timestamp in micrseconds.
///
/// This constructor is used for unit test only. Real [FrameTiming]s should
/// be retrieved from [Window.onReportTimings].
///
/// TODO(CareF): This is part of #20229. Remove back to default constructor
/// after #20229 lands and corresponding framwork PRs land.
factory FrameTiming.fromTimeStamps({
int? vsyncStart,
required int buildStart,
required int buildFinish,
required int rasterStart,
required int rasterFinish
}) {
return FrameTiming._(<int>[
// This is for temporarily backward compatiblilty.
vsyncStart ?? buildStart,
buildStart,
buildFinish,
rasterStart,
rasterFinish
]);
}
/// This is a raw timestamp in microseconds from some epoch. The epoch in all
/// [FrameTiming] is the same, but it may not match [DateTime]'s epoch.
int timestampInMicroseconds(FramePhase phase) => _timestamps[phase.index];

24
lib/web_ui/lib/src/ui/window.dart
View File

@ -1070,30 +1070,6 @@ class FrameTiming {
FrameTiming._(List<int> timestamps)
: assert(timestamps.length == FramePhase.values.length), _timestamps = timestamps;
/// Construct [FrameTiming] with given timestamp in micrseconds.
///
/// This constructor is used for unit test only. Real [FrameTiming]s should
/// be retrieved from [Window.onReportTimings].
///
/// TODO(CareF): This is part of #20229. Remove back to default constructor
/// after #20229 lands and corresponding framwork PRs land.
factory FrameTiming.fromTimeStamps({
int? vsyncStart,
required int buildStart,
required int buildFinish,
required int rasterStart,
required int rasterFinish
}) {
return FrameTiming._(<int>[
// This is for temporarily backward compatiblilty.
vsyncStart ?? buildStart,
buildStart,
buildFinish,
rasterStart,
rasterFinish
]);
}
/// This is a raw timestamp in microseconds from some epoch. The epoch in all
/// [FrameTiming] is the same, but it may not match [DateTime]'s epoch.
int timestampInMicroseconds(FramePhase phase) => _timestamps[phase.index];