From 8b3aabd61dfd7b7b525ae4be04093ba507d1455a Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Fri, 24 Jun 2022 23:19:40 -0700 Subject: [PATCH] Fix BidirectionalIterator deprecation warning and roll engine to a1dd50405992 (#106595) * a1dd50405 Roll Dart SDK from 692562354d6d to 48e3f8edb811 (3 revisions) (flutter/engine#34282) * Fix BidirectionalIterator deprecation warning * Remove override for movePrevious Co-authored-by: engine-flutter-autoroll --- bin/internal/engine.version | 2 +- packages/flutter/lib/src/rendering/editable.dart | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/bin/internal/engine.version b/bin/internal/engine.version index d9461cb2452..7291d62d55f 100644 --- a/bin/internal/engine.version +++ b/bin/internal/engine.version @@ -1 +1 @@ -4446e3edda6a3ef9dd34afcabb5ebff0747d5f93 +a1dd504059925c9925ad9d36f0cf67ad8ea62eb0 diff --git a/packages/flutter/lib/src/rendering/editable.dart b/packages/flutter/lib/src/rendering/editable.dart index f9701da092d..9cc430ef462 100644 --- a/packages/flutter/lib/src/rendering/editable.dart +++ b/packages/flutter/lib/src/rendering/editable.dart @@ -112,7 +112,7 @@ class TextSelectionPoint { /// the [VerticalCaretMovementRun] must not be used. The [isValid] property must /// be checked before calling [movePrevious] and [moveNext], or accessing /// [current]. -class VerticalCaretMovementRun extends BidirectionalIterator { +class VerticalCaretMovementRun extends Iterator { VerticalCaretMovementRun._( this._editable, this._lineMetrics, @@ -186,7 +186,9 @@ class VerticalCaretMovementRun extends BidirectionalIterator { return true; } - @override + /// Move back to the previous element. + /// + /// Returns true and updates [current] if successful. bool movePrevious() { assert(isValid); if (_currentLine <= 0) {