DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix warning about settings unavailable GN arg build_glfw_shell (#9642)

Browse Source 
This is only available on Darwin & Linux host targets. On Android target builds, the logic amounted to says “Don’t build GLFW on Android targets”. Since GLFW on Android does not make sense and the target does not exist, GN was generating a warning.
This commit is contained in:
Chinmay Garde 2019-07-01 16:58:00 -07:00 committed by GitHub
parent f66571781f
commit 8ac7cbddac
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/gn
View File

@ -253,7 +253,8 @@ def to_gn_args(args):
if sys.platform == 'darwin':
gn_args['mac_sdk_path'] = args.mac_sdk_path
gn_args['build_glfw_shell'] = args.build_glfw_shell
if args.build_glfw_shell:
gn_args['build_glfw_shell'] = True
if gn_args['mac_sdk_path'] == '':
gn_args['mac_sdk_path'] = os.getenv('FLUTTER_MAC_SDK_PATH', '')