DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" (flutter/engine#54250)

Browse Source 
Reverts: flutter/engine#54240
Initiated by: zanderso
Reason for reverting: Looks like some issue with file permissions https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20plugin_test_macos/19179/overview
Original PR Author: cbracken

Reviewed By: {zanderso}

This change reverts the following previous change:
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location.

Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.

Issue: https://github.com/flutter/flutter/issues/107884

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This commit is contained in:
auto-submit[bot] 2024-07-31 14:12:47 +00:00 committed by GitHub
parent ad6c555ceb
commit 8a06eaf695
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/sky/tools/create_full_ios_framework.py
View File

@ -243,7 +243,7 @@ def _generate_gen_snapshot(gen_snapshot_path, destination):
print('Cannot find gen_snapshot at %s' % gen_snapshot_path)
sys.exit(1)
shutil.copyfile(gen_snapshot_path, destination)
subprocess.check_call(['xcrun', 'bitcode_strip', '-r', gen_snapshot_path, '-o', destination])
if __name__ == '__main__':

3
engine/src/flutter/sky/tools/create_macos_gen_snapshots.py
View File

@ -5,7 +5,6 @@
# found in the LICENSE file.
import argparse
import shutil
import subprocess
import sys
import os
@ -70,7 +69,7 @@ def generate_gen_snapshot(gen_snapshot_path, destination):
print('Cannot find gen_snapshot at %s' % gen_snapshot_path)
sys.exit(1)
shutil.copyfile(gen_snapshot_path, destination)
subprocess.check_call(['xcrun', 'bitcode_strip', '-r', gen_snapshot_path, '-o', destination])
if __name__ == '__main__':