DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make EncodableValue::LongValue const (flutter/engine#25335)

Browse Source 
This method doesn't mutate the value of the underlying variant.

Fixes https://github.com/flutter/flutter/issues/79472
This commit is contained in:
Chris Bracken 2021-03-31 12:47:49 -07:00 committed by GitHub
parent 20b6f2a4ea
commit 896ed97baf
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/shell/platform/common/client_wrapper/encodable_value_unittests.cc
View File

@ -33,10 +33,10 @@ TEST(EncodableValueTest, Int) {
// Test the int/long convenience wrapper.
TEST(EncodableValueTest, LongValue) {
EncodableValue value(std::numeric_limits<int32_t>::max());
EXPECT_EQ(value.LongValue(), std::numeric_limits<int32_t>::max());
value = std::numeric_limits<int64_t>::max();
EXPECT_EQ(value.LongValue(), std::numeric_limits<int64_t>::max());
const EncodableValue int_value(std::numeric_limits<int32_t>::max());
EXPECT_EQ(int_value.LongValue(), std::numeric_limits<int32_t>::max());
const EncodableValue long_value(std::numeric_limits<int64_t>::max());
EXPECT_EQ(long_value.LongValue(), std::numeric_limits<int64_t>::max());
}
TEST(EncodableValueTest, Long) {

2
engine/src/flutter/shell/platform/common/client_wrapper/include/flutter/encodable_value.h
View File

@ -203,7 +203,7 @@ class EncodableValue : public internal::EncodableValueVariant {
//
// Calling this method if the value doesn't contain either an int32_t or an
// int64_t will throw an exception.
int64_t LongValue() {
int64_t LongValue() const {
if (std::holds_alternative<int32_t>(*this)) {
return std::get<int32_t>(*this);
}