From 893d8ae2e70caff986b0a0c528b591cc5e92244f Mon Sep 17 00:00:00 2001
From: Ojan Vafai <ojan@chromium.org>
Date: Tue, 14 Apr 2015 13:57:07 -0700
Subject: [PATCH] Fix crash when removing layout managers.

We weren't correctly marking an element as needing style
recalc if it was *losing* it's layout manager. We were
only doing so when it was gaining a layout manager for
the first time.

Review URL: https://codereview.chromium.org/1082273004
---
 engine/src/flutter/tests/layout/custom.sky | 47 ++++++++++++++++++----
 1 file changed, 40 insertions(+), 7 deletions(-)

diff --git a/engine/src/flutter/tests/layout/custom.sky b/engine/src/flutter/tests/layout/custom.sky
index b3892a873c1..586dd26fe9d 100644
--- a/engine/src/flutter/tests/layout/custom.sky
+++ b/engine/src/flutter/tests/layout/custom.sky
@@ -1,9 +1,11 @@
-<parent style='background-color: lightblue;'>
-  <child style='background-color: pink;'>
-    <grandchild style='background-color: red; width: 25px; height: 25px;'></grandchild>
-  </child>
-  <child2 style='background-color: salmon; height: 25px;' />
-</parent>
+<root style="width: 300px">
+  <parent style='background-color: lightblue;'>
+    <child style='background-color: pink;'>
+      <grandchild style='background-color: red; width: 25px; height: 25px;'></grandchild>
+    </child>
+    <child2 style='background-color: salmon; height: 25px;' />
+  </parent>
+</root>
 
 <script>
 import "../resources/third_party/unittest/unittest.dart";
@@ -20,6 +22,7 @@ void main() {
   var parent = document.querySelector('parent');
   var firstChild = parent.firstElementChild;
   var secondChild = parent.lastElementChild;
+  var grandChild = document.querySelector('grandchild');
 
   parent.setLayoutManager(() {
     if (first) {
@@ -58,6 +61,11 @@ void main() {
     expect(secondChild.offsetHeight, equals(25));
     expect(secondChild.offsetTop, equals(0));
     expect(secondChild.offsetLeft, equals(0));
+
+    expect(grandChild.offsetWidth, equals(25));
+    expect(grandChild.offsetHeight, equals(25));
+    expect(secondChild.offsetTop, equals(0));
+    expect(secondChild.offsetLeft, equals(0));
   };
 
   test("should have the right sizes after layout", () {
@@ -75,7 +83,32 @@ void main() {
         expect(parent.offsetWidth, equals(150));
         expect(secondChild.offsetWidth, equals(150));
         assertNonChangingValues();
-        completer.complete();
+
+        parent.setLayoutManager(null);
+
+        window.requestAnimationFrame((_) {
+          expect(parent.offsetWidth, equals(300));
+          expect(parent.offsetHeight, equals(50));
+          expect(parent.offsetTop, equals(0));
+          expect(parent.offsetLeft, equals(0));
+
+          expect(firstChild.offsetWidth, equals(300));
+          expect(firstChild.offsetHeight, equals(25));
+          expect(firstChild.offsetTop, equals(0));
+          expect(firstChild.offsetLeft, equals(0));
+
+          expect(secondChild.offsetWidth, equals(300));
+          expect(secondChild.offsetHeight, equals(25));
+          expect(secondChild.offsetTop, equals(25));
+          expect(secondChild.offsetLeft, equals(0));
+
+          expect(grandChild.offsetWidth, equals(25));
+          expect(grandChild.offsetHeight, equals(25));
+          expect(grandChild.offsetTop, equals(0));
+          expect(grandChild.offsetLeft, equals(0));
+
+          completer.complete();
+        });
       });
     });