DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix menu_anchor_test.dart's state leak (#112718)

Browse Source 
Merging on red to green the build.
This commit is contained in:
Greg Spencer 2022-09-30 10:40:47 -07:00 committed by GitHub
parent 99fb2d36e8
commit 874ea75dce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/flutter/test/material/menu_anchor_test.dart
View File

@ -16,6 +16,7 @@ void main() {
final List<TestMenu> opened = <TestMenu>[];
final List<TestMenu> closed = <TestMenu>[];
final GlobalKey menuItemKey = GlobalKey();
late Size defaultSize;
void onPressed(TestMenu item) {
selected.add(item);
@ -33,6 +34,11 @@ void main() {
focusedMenu = primaryFocus?.debugLabel ?? primaryFocus?.toString();
}
setUpAll(() {
final MediaQueryData mediaQueryData = MediaQueryData.fromWindow(TestWidgetsFlutterBinding.instance.window);
defaultSize = mediaQueryData.size;
});
setUp(() {
focusedMenu = null;
selected.clear();
@ -42,6 +48,13 @@ void main() {
focusedMenu = null;
});
Future<void> changeSurfaceSize(WidgetTester tester, Size size) async {
await tester.binding.setSurfaceSize(size);
addTearDown(() async {
await tester.binding.setSurfaceSize(defaultSize);
});
}
void listenForFocusChanges() {
FocusManager.instance.addListener(handleFocusChange);
addTearDown(() => FocusManager.instance.removeListener(handleFocusChange));
@ -1059,16 +1072,13 @@ void main() {
opened.clear();
const Size smallSize = Size(200, 200);
await tester.binding.setSurfaceSize(smallSize);
await changeSurfaceSize(tester, smallSize);
await tester.pumpWidget(build(smallSize));
await tester.pump();
expect(opened, isEmpty);
expect(closed, isNotEmpty);
// Reset binding when done.
await tester.binding.setSurfaceSize(mediaQueryData.size);
});
});
@ -1408,7 +1418,7 @@ void main() {
}
testWidgets('unconstrained menus show up in the right place in LTR', (WidgetTester tester) async {
await tester.binding.setSurfaceSize(const Size(800, 600));
await changeSurfaceSize(tester, const Size(800, 600));
await tester.pumpWidget(
MaterialApp(
home: Material(
@ -1446,7 +1456,7 @@ void main() {
});
testWidgets('unconstrained menus show up in the right place in RTL', (WidgetTester tester) async {
await tester.binding.setSurfaceSize(const Size(800, 600));
await changeSurfaceSize(tester, const Size(800, 600));
await tester.pumpWidget(
MaterialApp(
home: Directionality(
@ -1487,7 +1497,7 @@ void main() {
});
testWidgets('constrained menus show up in the right place in LTR', (WidgetTester tester) async {
await tester.binding.setSurfaceSize(const Size(300, 300));
await changeSurfaceSize(tester, const Size(300, 300));
await tester.pumpWidget(
MaterialApp(
home: Builder(
@ -1526,7 +1536,7 @@ void main() {
});
testWidgets('constrained menus show up in the right place in RTL', (WidgetTester tester) async {
await tester.binding.setSurfaceSize(const Size(300, 300));
await changeSurfaceSize(tester, const Size(300, 300));
await tester.pumpWidget(
MaterialApp(
home: Builder(