DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove URL shortening from GitHub reporter similar issues URL (#53882)

Browse Source
This commit is contained in:
Jenn Magder 2020-04-03 10:32:55 -07:00 committed by GitHub
parent b336452cde
commit 85ad699865
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/runner.dart
View File

@ -165,7 +165,7 @@ Future<void> _informUserOfCrash(List<String> args, dynamic error, StackTrace sta
flutterProjectFactory: globals.projectFactory,
client: clientFactory != null ? clientFactory() : HttpClient(),
);
final String similarIssuesURL = await gitHubTemplateCreator.toolCrashSimilarIssuesGitHubURL(errorString);
final String similarIssuesURL = GitHubTemplateCreator.toolCrashSimilarIssuesURL(errorString);
globals.printStatus('$similarIssuesURL\n', wrap: false);
globals.printStatus('To report your crash to the Flutter team, first read the guide to filing a bug.', emphasis: true);
globals.printStatus('https://flutter.dev/docs/resources/bug-reports\n', wrap: false);

5
packages/flutter_tools/lib/src/reporting/github_template.dart
View File

@ -32,9 +32,8 @@ class GitHubTemplateCreator {
final FlutterProjectFactory _flutterProjectFactory;
final HttpClient _client;
Future<String> toolCrashSimilarIssuesGitHubURL(String errorString) async {
final String fullURL = 'https://github.com/flutter/flutter/issues?q=is%3Aissue+${Uri.encodeQueryComponent(errorString)}';
return await _shortURL(fullURL);
static String toolCrashSimilarIssuesURL(String errorString) {
return 'https://github.com/flutter/flutter/issues?q=is%3Aissue+${Uri.encodeQueryComponent(errorString)}';
}
/// GitHub URL to present to the user containing encoded suggested template.

26
packages/flutter_tools/test/general.shard/github_template_test.dart
View File

@ -24,33 +24,13 @@ void main() {
});
group('GitHub template creator', () {
testWithoutContext('similar issues URL', () async {
final GitHubTemplateCreator creator = GitHubTemplateCreator(
fileSystem: fs,
logger: logger,
client: SuccessShortenURLFakeHttpClient(),
flutterProjectFactory: FlutterProjectFactory(),
);
testWithoutContext('similar issues URL', () {
expect(
await creator.toolCrashSimilarIssuesGitHubURL('this is a 100% error'),
_kShortURL
GitHubTemplateCreator.toolCrashSimilarIssuesURL('this is a 100% error'),
'https://github.com/flutter/flutter/issues?q=is%3Aissue+this+is+a+100%25+error',
);
});
testWithoutContext('similar issues URL with network failure', () async {
final GitHubTemplateCreator creator = GitHubTemplateCreator(
fileSystem: fs,
logger: logger,
client: FakeHttpClient(),
flutterProjectFactory: FlutterProjectFactory(),
);
expect(
await creator.toolCrashSimilarIssuesGitHubURL('this is a 100% error'),
'https://github.com/flutter/flutter/issues?q=is%3Aissue+this+is+a+100%25+error'
);
expect(logger.traceText, contains('Failed to shorten GitHub template URL'));
});
group('new issue template URL', () {
StackTrace stackTrace;
const String command = 'flutter test';

5
packages/flutter_tools/test/general.shard/runner/runner_test.dart
View File

@ -81,9 +81,6 @@ void main() {
});
testUsingContext('GitHub issue template', () async {
const String similarURL = 'https://example.com/1';
when(mockGitHubTemplateCreator.toolCrashSimilarIssuesGitHubURL(any))
.thenAnswer((_) async => similarURL);
const String templateURL = 'https://example.com/2';
when(mockGitHubTemplateCreator.toolCrashIssueTemplateGitHubURL(any, any, any, any, any))
.thenAnswer((_) async => templateURL);
@ -115,7 +112,7 @@ void main() {
expect(errorText, contains('Oops; flutter has exited unexpectedly: "an exception % --".\n'));
final String statusText = testLogger.statusText;
expect(statusText, contains(similarURL));
expect(statusText, contains('https://github.com/flutter/flutter/issues?q=is%3Aissue+an+exception+%25+--'));
expect(statusText, contains('https://flutter.dev/docs/resources/bug-reports'));
expect(statusText, contains(templateURL));