DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1083 from Hixie/card-bug

Browse Source 
Avoid infinite loop in syncChildren().
This commit is contained in:
Ian Hickson 2015-09-08 14:03:51 -07:00
commit 832da04002
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/flutter/lib/src/widgets/framework.dart
View File

@ -563,8 +563,7 @@ abstract class TagNode extends Widget {
void _sync(Widget old, dynamic slot) {
assert(!_debugChildTaken);
Widget oldChild = (old as TagNode)?.child;
child = syncChild(child, oldChild, slot);
child = syncChild(child, (old as TagNode)?.child, slot);
if (child != null) {
assert(child.parent == this);
assert(child.renderObject != null);
@ -945,6 +944,12 @@ abstract class StatefulComponent extends Component {
fn();
_scheduleBuild();
}
String toStringName([String prefix = '', String startPrefix = '']) {
if (_disqualifiedFromEverAppearingAgain)
return '[[DISQUALIFIED]] ${super.toStringName()}';
return super.toStringName();
}
}
Set<Component> _dirtyComponents = new Set<Component>();
@ -1228,8 +1233,8 @@ abstract class RenderObjectWrapper extends Widget {
} else {
syncChild(null, oldChild, null);
}
oldChildrenBottom -= 1;
}
} // else the node was probably moved elsewhere, ignore it
oldChildrenBottom -= 1;
}
}