DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable embedder_unittests. (flutter/engine#9482)

Browse Source 
This was disabled in https://github.com/flutter/engine/pull/6798 waiting for
a Dart SDK patch to land e6d3a45b6a
which has long since been addressed.
This commit is contained in:
Chinmay Garde 2019-06-27 16:49:22 -07:00 committed by GitHub
parent f9893450a9
commit 8182a56965
2 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
engine/src/flutter/shell/platform/embedder/tests/embedder_a11y_unittests.cc
View File

@ -21,7 +21,10 @@ namespace testing {
using Embedder11yTest = testing::EmbedderTest;
TEST_F(Embedder11yTest, A11yTreeIsConsistent) {
// TODO: This test has been disabled as it is flaky (more reproducible in
// profile more). Multiple calls to a11y changed handler in Dart code is
// suspected. https://github.com/flutter/flutter/issues/35218
TEST_F(Embedder11yTest, DISABLED_A11yTreeIsConsistent) {
auto& context = GetEmbedderContext();
fml::AutoResetWaitableEvent latch;
@ -51,7 +54,8 @@ TEST_F(Embedder11yTest, A11yTreeIsConsistent) {
// Wait for initial NotifySemanticsEnabled(false).
callback = [&](Dart_NativeArguments args) {
bool enabled = true;
Dart_GetNativeBooleanArgument(args, 0, &enabled);
auto handle = Dart_GetNativeBooleanArgument(args, 0, &enabled);
ASSERT_FALSE(Dart_IsError(handle));
ASSERT_FALSE(enabled);
latch.Signal();
};
@ -60,7 +64,8 @@ TEST_F(Embedder11yTest, A11yTreeIsConsistent) {
// Enable semantics. Wait for NotifySemanticsEnabled(true).
callback = [&](Dart_NativeArguments args) {
bool enabled = false;
Dart_GetNativeBooleanArgument(args, 0, &enabled);
auto handle = Dart_GetNativeBooleanArgument(args, 0, &enabled);
ASSERT_FALSE(Dart_IsError(handle));
ASSERT_TRUE(enabled);
latch.Signal();
};
@ -71,7 +76,8 @@ TEST_F(Embedder11yTest, A11yTreeIsConsistent) {
// Wait for initial accessibility features (reduce_motion == false)
callback = [&](Dart_NativeArguments args) {
bool enabled = true;
Dart_GetNativeBooleanArgument(args, 0, &enabled);
auto handle = Dart_GetNativeBooleanArgument(args, 0, &enabled);
ASSERT_FALSE(Dart_IsError(handle));
ASSERT_FALSE(enabled);
latch.Signal();
};
@ -80,7 +86,8 @@ TEST_F(Embedder11yTest, A11yTreeIsConsistent) {
// Set accessibility features: (reduce_motion == true)
callback = [&](Dart_NativeArguments args) {
bool enabled = false;
Dart_GetNativeBooleanArgument(args, 0, &enabled);
auto handle = Dart_GetNativeBooleanArgument(args, 0, &enabled);
ASSERT_FALSE(Dart_IsError(handle));
ASSERT_TRUE(enabled);
latch.Signal();
};
@ -136,7 +143,8 @@ TEST_F(Embedder11yTest, A11yTreeIsConsistent) {
ASSERT_EQ(42, node_id);
int64_t action_id;
Dart_GetNativeIntegerArgument(args, 1, &action_id);
auto handle = Dart_GetNativeIntegerArgument(args, 1, &action_id);
ASSERT_FALSE(Dart_IsError(handle));
ASSERT_EQ(static_cast<int32_t>(flutter::SemanticsAction::kTap), action_id);
Dart_Handle semantic_args = Dart_GetNativeArgument(args, 2);

5
engine/src/flutter/testing/run_tests.sh
View File

@ -24,8 +24,9 @@ fi
# Switch to buildroot dir. Some tests assume paths relative to buildroot.
cd "$BUILDROOT_DIR"
# TODO(dnfield): Re-enable this when the upstream Dart changes that make it not be flaky land.
# $HOST_DIR/embedder_unittests
echo "Running embedder_unittests..."
"$HOST_DIR/embedder_unittests"
echo "Running flow_unittests..."
"$HOST_DIR/flow_unittests"