From 8046e1337306ad3f57d522aacdae38dd2d73fdde Mon Sep 17 00:00:00 2001
From: Jackson Gardner <jacksongardner@google.com>
Date: Wed, 26 Jul 2023 10:10:07 -0700
Subject: [PATCH] Run benchmarks with `--omit-type-checks` (#131102)

We've decided to use the `--omit-type-checks` flag for our dart2wasm benchmarks. Right now, many of the benchmark results are dominated by type checks and most of what we are actually trying to measure get drowned out in the noise.
---
 .ci.yaml                                    | 2 --
 dev/devicelab/lib/tasks/web_benchmarks.dart | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/.ci.yaml b/.ci.yaml
index ce37a5f61b2..22ccf43eebb 100644
--- a/.ci.yaml
+++ b/.ci.yaml
@@ -1079,7 +1079,6 @@ targets:
 
   - name: Linux web_benchmarks_html
     recipe: devicelab/devicelab_drone
-    presubmit: false
     timeout: 60
     properties:
       dependencies: >-
@@ -1096,7 +1095,6 @@ targets:
       - .ci.yaml
 
   - name: Linux web_benchmarks_skwasm
-    bringup: true
     recipe: devicelab/devicelab_drone
     presubmit: false
     timeout: 60
diff --git a/dev/devicelab/lib/tasks/web_benchmarks.dart b/dev/devicelab/lib/tasks/web_benchmarks.dart
index 051133c70db..a4748b8f9f8 100644
--- a/dev/devicelab/lib/tasks/web_benchmarks.dart
+++ b/dev/devicelab/lib/tasks/web_benchmarks.dart
@@ -36,6 +36,7 @@ Future<TaskResult> runWebBenchmark(WebBenchmarkOptions benchmarkOptions) async {
       if (benchmarkOptions.useWasm) ...<String>[
         '--wasm',
         '--wasm-opt=debug',
+        '--omit-type-checks',
       ],
       '--dart-define=FLUTTER_WEB_ENABLE_PROFILING=true',
       '--web-renderer=${benchmarkOptions.webRenderer}',