From 7ffca994cc25d0cc4cd2cdee63832ad0b5bf059b Mon Sep 17 00:00:00 2001 From: Ferhat Date: Tue, 26 Jan 2021 16:59:01 -0800 Subject: [PATCH] Fix flake due to shadow rendering difference on webkit (#23961) --- .../test/golden_tests/engine/compositing_golden_test.dart | 3 ++- lib/web_ui/test/golden_tests/golden_success_smoke_test.dart | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/web_ui/test/golden_tests/engine/compositing_golden_test.dart b/lib/web_ui/test/golden_tests/engine/compositing_golden_test.dart index 8657c53255a..b1d0babd2ad 100644 --- a/lib/web_ui/test/golden_tests/engine/compositing_golden_test.dart +++ b/lib/web_ui/test/golden_tests/engine/compositing_golden_test.dart @@ -265,7 +265,8 @@ void testMain() async { html.Element viewElement5 = builder5.build().webOnlyRootElement; html.document.body.append(viewElement5); await matchGoldenFile('compositing_physical_update_3.png', - region: region, maxDiffRatePercent: 0.4); + region: region, maxDiffRatePercent: + browserEngine == BrowserEngine.webkit ? 0.6 : 0.4); viewElement5.remove(); /// Update shadow color. diff --git a/lib/web_ui/test/golden_tests/golden_success_smoke_test.dart b/lib/web_ui/test/golden_tests/golden_success_smoke_test.dart index 563e3e92c72..dc28497e962 100644 --- a/lib/web_ui/test/golden_tests/golden_success_smoke_test.dart +++ b/lib/web_ui/test/golden_tests/golden_success_smoke_test.dart @@ -22,6 +22,8 @@ void testMain() async { test('screenshot test reports success', () async { html.document.body.style.fontFamily = 'Roboto'; html.document.body.innerHtml = 'Hello world!'; - await matchGoldenFile('__local__/smoke_test.png', region: Rect.fromLTWH(0, 0, 320, 200)); + // TODO: https://github.com/flutter/flutter/issues/74702 , reduce webkit percentage. + await matchGoldenFile('__local__/smoke_test.png', region: Rect.fromLTWH(0, 0, 320, 200), + maxDiffRatePercent: browserEngine == BrowserEngine.webkit ? 3.0 : 0.28); }); }