From 7c532f1ab8a6fff8efffbe934bcca82a2dee7581 Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Fri, 15 Dec 2023 16:30:16 -0800 Subject: [PATCH] [Impeller] Do not pass the depfile flag when creating a shader bundle in ImpellerC (flutter/engine#49114) Shader bundles only produce the flat buffer output and do not write a depfile. --- engine/src/flutter/impeller/tools/impeller.gni | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/engine/src/flutter/impeller/tools/impeller.gni b/engine/src/flutter/impeller/tools/impeller.gni index a07963ee380..db66f60a6d0 100644 --- a/engine/src/flutter/impeller/tools/impeller.gni +++ b/engine/src/flutter/impeller/tools/impeller.gni @@ -349,22 +349,21 @@ template("impellerc") { shader_target_flag = invoker.shader_target_flag - depfile_path = "$generated_dir/{{source_file_part}}.d" - depfile_intermediate_path = rebase_path(depfile_path, root_build_dir) - depfile = depfile_path - shader_lib_dir = rebase_path("//flutter/impeller/compiler/shader_lib") args = [ "--include=$shader_lib_dir", - "--depfile=$depfile_intermediate_path", "$shader_target_flag", ] # When we're in single invocation mode, we can't use source enumeration. if (!single_invocation) { + depfile_path = "$generated_dir/{{source_file_part}}.d" + depfile_intermediate_path = rebase_path(depfile_path, root_build_dir) + depfile = depfile_path args += [ "--input={{source}}", "--include={{source_dir}}", + "--depfile=$depfile_intermediate_path", ] }