From 79237f839bc27857472ecd95310dc7012eb60b7e Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Mon, 24 Jul 2023 11:15:52 -0700 Subject: [PATCH] [Impeller] provide cull rect to Canvas in GL/Vulakn impeller backend. (flutter/engine#43961) This was missing compared to the metal version. Doesn't matter on flutter/gallery but might matter elsewhere once platform views are working. --- engine/src/flutter/shell/gpu/gpu_surface_gl_impeller.cc | 4 ++-- engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/engine/src/flutter/shell/gpu/gpu_surface_gl_impeller.cc b/engine/src/flutter/shell/gpu/gpu_surface_gl_impeller.cc index 8b8c6e81c66..84372944eb6 100644 --- a/engine/src/flutter/shell/gpu/gpu_surface_gl_impeller.cc +++ b/engine/src/flutter/shell/gpu/gpu_surface_gl_impeller.cc @@ -108,8 +108,8 @@ std::unique_ptr GPUSurfaceGLImpeller::AcquireFrame( auto cull_rect = surface->GetTargetRenderPassDescriptor().GetRenderTargetSize(); - - impeller::DlDispatcher impeller_dispatcher; + impeller::Rect dl_cull_rect = impeller::Rect::MakeSize(cull_rect); + impeller::DlDispatcher impeller_dispatcher(dl_cull_rect); display_list->Dispatch( impeller_dispatcher, SkIRect::MakeWH(cull_rect.width, cull_rect.height)); diff --git a/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc b/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc index 27cf1fddbcc..08991317765 100644 --- a/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc +++ b/engine/src/flutter/shell/gpu/gpu_surface_vulkan_impeller.cc @@ -74,8 +74,8 @@ std::unique_ptr GPUSurfaceVulkanImpeller::AcquireFrame( auto cull_rect = surface->GetTargetRenderPassDescriptor().GetRenderTargetSize(); - - impeller::DlDispatcher impeller_dispatcher; + impeller::Rect dl_cull_rect = impeller::Rect::MakeSize(cull_rect); + impeller::DlDispatcher impeller_dispatcher(dl_cull_rect); display_list->Dispatch( impeller_dispatcher, SkIRect::MakeWH(cull_rect.width, cull_rect.height));