DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Windows] Ensure that the simulated raster thread finishes before returning from FlutterWindowsViewTest tests (#168171)

Browse Source 
These tests were flaking because the thread that calls
FlutterWindowsView::OnFramePresented could still be running after the
test exits and deletes the view.
This commit is contained in:
Jason Simmons 2025-05-01 23:29:59 +00:00 committed by GitHub
parent 8e7c68fb65
commit 78161a03ea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
engine/src/flutter/shell/platform/windows/flutter_windows_view_unittests.cc
View File

@ -926,17 +926,18 @@ TEST(FlutterWindowsViewTest, WindowResizeTests) {
}));
// Simulate raster thread.
std::thread([&metrics_sent_latch, &view]() {
std::thread frame_thread([&metrics_sent_latch, &view]() {
metrics_sent_latch.Wait();
// Frame generated and presented from the raster thread.
EXPECT_TRUE(view->OnFrameGenerated(500, 500));
view->OnFramePresented();
}).detach();
});
// Start the window resize. This sends the new window metrics
// and then blocks polling run loop until another thread completes the window
// resize.
EXPECT_TRUE(view->OnWindowSizeChanged(500, 500));
frame_thread.join();
}
// Verify that an empty frame completes a view resize.
@ -987,17 +988,18 @@ TEST(FlutterWindowsViewTest, TestEmptyFrameResizes) {
view_modifier.SetSurface(std::move(surface));
// Simulate raster thread.
std::thread([&metrics_sent_latch, &view]() {
std::thread frame_thread([&metrics_sent_latch, &view]() {
metrics_sent_latch.Wait();
// Empty frame generated and presented from the raster thread.
EXPECT_TRUE(view->OnEmptyFrameGenerated());
view->OnFramePresented();
}).detach();
});
// Start the window resize. This sends the new window metrics
// and then blocks until another thread completes the window resize.
EXPECT_TRUE(view->OnWindowSizeChanged(500, 500));
frame_thread.join();
}
// A window resize can be interleaved between a frame generation and