From 6ddcc5c032457cf775be4d485d98fc07e2af1575 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Sun, 18 Jun 2023 16:49:28 -0700 Subject: [PATCH] Fix prefer_final_in_foreach analysis errors (flutter/engine#42971) This is now failing the engine roll for some reason https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/58456/overview --- engine/src/flutter/lib/ui/painting.dart | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/engine/src/flutter/lib/ui/painting.dart b/engine/src/flutter/lib/ui/painting.dart index 5b8f9003cc7..dcce04e421e 100644 --- a/engine/src/flutter/lib/ui/painting.dart +++ b/engine/src/flutter/lib/ui/painting.dart @@ -5511,7 +5511,7 @@ abstract class Canvas { /// void paint(Canvas canvas, Size size) { /// Paint paint = Paint(); /// canvas.drawAtlas(spriteAtlas, [ - /// for (Sprite sprite in allSprites) + /// for (final Sprite sprite in allSprites) /// RSTransform.fromComponents( /// rotation: 0.0, /// scale: 1.0, @@ -5523,7 +5523,7 @@ abstract class Canvas { /// translateY: sprite.center.dy, /// ), /// ], [ - /// for (Sprite sprite in allSprites) + /// for (final Sprite sprite in allSprites) /// Rect.fromLTWH(sprite.index * 10.0, 0.0, 10.0, 10.0), /// ], null, null, null, paint); /// } @@ -5554,7 +5554,7 @@ abstract class Canvas { /// void paint(Canvas canvas, Size size) { /// Paint paint = Paint(); /// canvas.drawAtlas(spriteAtlas, [ - /// for (Sprite sprite in allSprites) + /// for (final Sprite sprite in allSprites) /// RSTransform.fromComponents( /// rotation: sprite.rotation, /// scale: 1.0, @@ -5566,10 +5566,10 @@ abstract class Canvas { /// translateY: sprite.center.dy, /// ), /// ], [ - /// for (Sprite sprite in allSprites) + /// for (final Sprite sprite in allSprites) /// Rect.fromLTWH(sprite.index * 10.0, 0.0, 10.0, 10.0), /// ], [ - /// for (Sprite sprite in allSprites) + /// for (final Sprite sprite in allSprites) /// Colors.white.withAlpha(sprite.alpha), /// ], BlendMode.srcIn, null, paint); /// }