diff --git a/engine/src/flutter/impeller/aiks/image.h b/engine/src/flutter/impeller/aiks/image.h index 093d74af9cf..4011137b403 100644 --- a/engine/src/flutter/impeller/aiks/image.h +++ b/engine/src/flutter/impeller/aiks/image.h @@ -13,7 +13,7 @@ namespace impeller { class Image { public: - Image(std::shared_ptr texture); + explicit Image(std::shared_ptr texture); ~Image(); diff --git a/engine/src/flutter/impeller/archivist/archive.cc b/engine/src/flutter/impeller/archivist/archive.cc index 022b30de514..1179da2f2f2 100644 --- a/engine/src/flutter/impeller/archivist/archive.cc +++ b/engine/src/flutter/impeller/archivist/archive.cc @@ -4,13 +4,10 @@ #include "impeller/archivist/archive.h" -#include - #include "flutter/fml/logging.h" #include "impeller/archivist/archive_class_registration.h" #include "impeller/archivist/archive_database.h" #include "impeller/archivist/archive_location.h" -#include "impeller/base/validation.h" namespace impeller { diff --git a/engine/src/flutter/impeller/archivist/archive.h b/engine/src/flutter/impeller/archivist/archive.h index a232bf4c544..33c3f669880 100644 --- a/engine/src/flutter/impeller/archivist/archive.h +++ b/engine/src/flutter/impeller/archivist/archive.h @@ -9,9 +9,7 @@ #include #include #include -#include -#include "flutter/fml/macros.h" #include "impeller/archivist/archivable.h" namespace impeller { @@ -21,7 +19,7 @@ class ArchiveDatabase; class Archive { public: - Archive(const std::string& path); + explicit Archive(const std::string& path); ~Archive(); @@ -45,7 +43,7 @@ class Archive { template ::value>> - [[nodiscard]] size_t Read(UnarchiveStep stepper) { + [[nodiscard]] size_t Read(const UnarchiveStep& stepper) { const ArchiveDef& def = T::kArchiveDefinition; return UnarchiveInstances(def, stepper); } diff --git a/engine/src/flutter/impeller/archivist/archive_database.h b/engine/src/flutter/impeller/archivist/archive_database.h index 57696313c7e..e8376fc3701 100644 --- a/engine/src/flutter/impeller/archivist/archive_database.h +++ b/engine/src/flutter/impeller/archivist/archive_database.h @@ -8,7 +8,6 @@ #include #include -#include "flutter/fml/macros.h" #include "impeller/archivist/archive_transaction.h" namespace impeller { @@ -22,7 +21,7 @@ struct ArchiveDef; /// class ArchiveDatabase { public: - ArchiveDatabase(const std::string& filename); + explicit ArchiveDatabase(const std::string& filename); ~ArchiveDatabase(); diff --git a/engine/src/flutter/impeller/archivist/archive_location.h b/engine/src/flutter/impeller/archivist/archive_location.h index 3caf3f1d8b2..6b773274ad4 100644 --- a/engine/src/flutter/impeller/archivist/archive_location.h +++ b/engine/src/flutter/impeller/archivist/archive_location.h @@ -7,7 +7,6 @@ #include #include -#include "flutter/fml/macros.h" #include "impeller/archivist/archivable.h" #include "impeller/archivist/archive.h" #include "impeller/base/allocation.h" diff --git a/engine/src/flutter/impeller/archivist/archive_statement.h b/engine/src/flutter/impeller/archivist/archive_statement.h index 69c746c234a..a5de60f865b 100644 --- a/engine/src/flutter/impeller/archivist/archive_statement.h +++ b/engine/src/flutter/impeller/archivist/archive_statement.h @@ -7,7 +7,6 @@ #include #include -#include "flutter/fml/macros.h" #include "impeller/base/allocation.h" namespace impeller { diff --git a/engine/src/flutter/impeller/archivist/archive_transaction.h b/engine/src/flutter/impeller/archivist/archive_transaction.h index 8e4d995d065..671074cb154 100644 --- a/engine/src/flutter/impeller/archivist/archive_transaction.h +++ b/engine/src/flutter/impeller/archivist/archive_transaction.h @@ -5,8 +5,6 @@ #include -#include "flutter/fml/macros.h" - namespace impeller { class ArchiveStatement; diff --git a/engine/src/flutter/impeller/archivist/archive_vector.h b/engine/src/flutter/impeller/archivist/archive_vector.h index e99e39d3620..2db657a6837 100644 --- a/engine/src/flutter/impeller/archivist/archive_vector.h +++ b/engine/src/flutter/impeller/archivist/archive_vector.h @@ -4,7 +4,6 @@ #pragma once -#include "flutter/fml/macros.h" #include "impeller/archivist/archive.h" namespace impeller { @@ -28,7 +27,7 @@ class ArchiveVector : public Archivable { ArchiveVector(); - ArchiveVector(std::vector keys); + explicit ArchiveVector(std::vector keys); ArchiveVector(const ArchiveVector&) = delete; diff --git a/engine/src/flutter/impeller/base/validation.h b/engine/src/flutter/impeller/base/validation.h index eb8bd8adb65..1e7671adaa0 100644 --- a/engine/src/flutter/impeller/base/validation.h +++ b/engine/src/flutter/impeller/base/validation.h @@ -12,8 +12,6 @@ #include -#include "flutter/fml/macros.h" - namespace impeller { class ValidationLog { diff --git a/engine/src/flutter/impeller/compiler/compiler_backend.h b/engine/src/flutter/impeller/compiler/compiler_backend.h index e06ec4ccfc4..ea278014398 100644 --- a/engine/src/flutter/impeller/compiler/compiler_backend.h +++ b/engine/src/flutter/impeller/compiler/compiler_backend.h @@ -47,7 +47,7 @@ struct CompilerBackend { spirv_cross::Compiler* GetCompiler(); - operator bool() const; + explicit operator bool() const; enum class ExtendedResourceIndex { kPrimary, diff --git a/engine/src/flutter/impeller/compiler/includer.h b/engine/src/flutter/impeller/compiler/includer.h index baeddb440b3..a3af915317a 100644 --- a/engine/src/flutter/impeller/compiler/includer.h +++ b/engine/src/flutter/impeller/compiler/includer.h @@ -6,7 +6,6 @@ #include -#include "flutter/fml/macros.h" #include "flutter/fml/mapping.h" #include "impeller/compiler/include_dir.h" #include "shaderc/shaderc.hpp" diff --git a/engine/src/flutter/impeller/compiler/logger.h b/engine/src/flutter/impeller/compiler/logger.h index 0c478b75d03..d96de575ba3 100644 --- a/engine/src/flutter/impeller/compiler/logger.h +++ b/engine/src/flutter/impeller/compiler/logger.h @@ -8,14 +8,13 @@ #include #include "flutter/fml/logging.h" -#include "flutter/fml/macros.h" namespace impeller { namespace compiler { class AutoLogger { public: - AutoLogger(std::stringstream& logger) : logger_(logger) {} + explicit AutoLogger(std::stringstream& logger) : logger_(logger) {} ~AutoLogger() { logger_ << std::endl; diff --git a/engine/src/flutter/impeller/compiler/source_options.h b/engine/src/flutter/impeller/compiler/source_options.h index 8a740c69a29..5c9983284d7 100644 --- a/engine/src/flutter/impeller/compiler/source_options.h +++ b/engine/src/flutter/impeller/compiler/source_options.h @@ -9,7 +9,6 @@ #include #include -#include "flutter/fml/macros.h" #include "flutter/fml/unique_fd.h" #include "impeller/compiler/include_dir.h" #include "impeller/compiler/types.h" diff --git a/engine/src/flutter/impeller/compiler/spirv_compiler.h b/engine/src/flutter/impeller/compiler/spirv_compiler.h index 6935f4a0fa4..c688cd2b46a 100644 --- a/engine/src/flutter/impeller/compiler/spirv_compiler.h +++ b/engine/src/flutter/impeller/compiler/spirv_compiler.h @@ -7,7 +7,6 @@ #include #include -#include "flutter/fml/macros.h" #include "flutter/fml/mapping.h" #include "impeller/compiler/includer.h" #include "impeller/compiler/source_options.h" diff --git a/engine/src/flutter/impeller/compiler/spirv_sksl.h b/engine/src/flutter/impeller/compiler/spirv_sksl.h index 7df5a76c84a..8e4879d02e2 100644 --- a/engine/src/flutter/impeller/compiler/spirv_sksl.h +++ b/engine/src/flutter/impeller/compiler/spirv_sksl.h @@ -10,7 +10,6 @@ #include #include "flutter/fml/logging.h" -#include "flutter/fml/macros.h" #include "spirv_glsl.hpp" namespace impeller { diff --git a/engine/src/flutter/impeller/compiler/switches.h b/engine/src/flutter/impeller/compiler/switches.h index c1911359c60..c159f1a9cc5 100644 --- a/engine/src/flutter/impeller/compiler/switches.h +++ b/engine/src/flutter/impeller/compiler/switches.h @@ -9,9 +9,7 @@ #include #include "flutter/fml/command_line.h" -#include "flutter/fml/macros.h" #include "flutter/fml/unique_fd.h" -#include "impeller/compiler/compiler.h" #include "impeller/compiler/include_dir.h" #include "impeller/compiler/types.h" diff --git a/engine/src/flutter/impeller/compiler/utilities.h b/engine/src/flutter/impeller/compiler/utilities.h index 4c110788832..d1d27436ac0 100644 --- a/engine/src/flutter/impeller/compiler/utilities.h +++ b/engine/src/flutter/impeller/compiler/utilities.h @@ -8,8 +8,6 @@ #include #include -#include "flutter/fml/macros.h" - namespace impeller { namespace compiler { diff --git a/engine/src/flutter/impeller/core/allocator.h b/engine/src/flutter/impeller/core/allocator.h index d43696b1308..5c4c02b78f1 100644 --- a/engine/src/flutter/impeller/core/allocator.h +++ b/engine/src/flutter/impeller/core/allocator.h @@ -4,9 +4,6 @@ #pragma once -#include - -#include "flutter/fml/macros.h" #include "flutter/fml/mapping.h" #include "impeller/core/device_buffer_descriptor.h" #include "impeller/core/texture.h" diff --git a/engine/src/flutter/impeller/core/buffer_view.h b/engine/src/flutter/impeller/core/buffer_view.h index 12c888b399a..1a272a8b29f 100644 --- a/engine/src/flutter/impeller/core/buffer_view.h +++ b/engine/src/flutter/impeller/core/buffer_view.h @@ -4,7 +4,6 @@ #pragma once -#include "flutter/fml/macros.h" #include "impeller/core/buffer.h" #include "impeller/core/range.h" diff --git a/engine/src/flutter/impeller/core/device_buffer.h b/engine/src/flutter/impeller/core/device_buffer.h index 9b1f594983e..ac0d454df28 100644 --- a/engine/src/flutter/impeller/core/device_buffer.h +++ b/engine/src/flutter/impeller/core/device_buffer.h @@ -7,7 +7,6 @@ #include #include -#include "flutter/fml/macros.h" #include "impeller/core/allocator.h" #include "impeller/core/buffer.h" #include "impeller/core/buffer_view.h" diff --git a/engine/src/flutter/impeller/core/formats.h b/engine/src/flutter/impeller/core/formats.h index 0e8d0d7d86a..fbf1a36321c 100644 --- a/engine/src/flutter/impeller/core/formats.h +++ b/engine/src/flutter/impeller/core/formats.h @@ -12,7 +12,6 @@ #include "flutter/fml/hash_combine.h" #include "flutter/fml/logging.h" -#include "flutter/fml/macros.h" #include "impeller/geometry/color.h" #include "impeller/geometry/rect.h" #include "impeller/geometry/scalar.h" diff --git a/engine/src/flutter/impeller/core/host_buffer.h b/engine/src/flutter/impeller/core/host_buffer.h index 9913b8ff46c..74997ebbe56 100644 --- a/engine/src/flutter/impeller/core/host_buffer.h +++ b/engine/src/flutter/impeller/core/host_buffer.h @@ -9,7 +9,6 @@ #include #include -#include "flutter/fml/macros.h" #include "impeller/base/allocation.h" #include "impeller/core/buffer.h" #include "impeller/core/buffer_view.h" diff --git a/engine/src/flutter/impeller/core/resource_binder.h b/engine/src/flutter/impeller/core/resource_binder.h index a88e75649d9..1afe75b861a 100644 --- a/engine/src/flutter/impeller/core/resource_binder.h +++ b/engine/src/flutter/impeller/core/resource_binder.h @@ -10,7 +10,6 @@ #include #include "flutter/fml/logging.h" -#include "flutter/fml/macros.h" #include "impeller/core/buffer_view.h" #include "impeller/core/formats.h" #include "impeller/core/sampler.h" diff --git a/engine/src/flutter/impeller/core/sampler.h b/engine/src/flutter/impeller/core/sampler.h index 8337997326f..5792aaacbc0 100644 --- a/engine/src/flutter/impeller/core/sampler.h +++ b/engine/src/flutter/impeller/core/sampler.h @@ -4,7 +4,6 @@ #pragma once -#include "flutter/fml/macros.h" #include "impeller/core/sampler_descriptor.h" namespace impeller { diff --git a/engine/src/flutter/impeller/core/sampler_descriptor.h b/engine/src/flutter/impeller/core/sampler_descriptor.h index b9292cff94d..197e373f9aa 100644 --- a/engine/src/flutter/impeller/core/sampler_descriptor.h +++ b/engine/src/flutter/impeller/core/sampler_descriptor.h @@ -6,7 +6,6 @@ #include -#include "flutter/fml/macros.h" #include "impeller/base/comparable.h" #include "impeller/core/formats.h" diff --git a/engine/src/flutter/impeller/core/texture_descriptor.h b/engine/src/flutter/impeller/core/texture_descriptor.h index aa1b574bf2d..e168895c673 100644 --- a/engine/src/flutter/impeller/core/texture_descriptor.h +++ b/engine/src/flutter/impeller/core/texture_descriptor.h @@ -4,11 +4,8 @@ #pragma once -#include - #include "impeller/core/formats.h" #include "impeller/geometry/size.h" -#include "impeller/image/decompressed_image.h" namespace impeller { diff --git a/engine/src/flutter/impeller/core/vertex_buffer.h b/engine/src/flutter/impeller/core/vertex_buffer.h index 1c62fc8b3b8..5ef934f4b82 100644 --- a/engine/src/flutter/impeller/core/vertex_buffer.h +++ b/engine/src/flutter/impeller/core/vertex_buffer.h @@ -17,7 +17,7 @@ struct VertexBuffer { size_t vertex_count = 0u; IndexType index_type = IndexType::kUnknown; - constexpr operator bool() const { + constexpr explicit operator bool() const { return static_cast(vertex_buffer) && (index_type == IndexType::kNone || static_cast(index_buffer)); } diff --git a/engine/src/flutter/impeller/display_list/dl_dispatcher.h b/engine/src/flutter/impeller/display_list/dl_dispatcher.h index 9e604dd4acf..10ed7fc6104 100644 --- a/engine/src/flutter/impeller/display_list/dl_dispatcher.h +++ b/engine/src/flutter/impeller/display_list/dl_dispatcher.h @@ -5,7 +5,6 @@ #pragma once #include "flutter/display_list/dl_op_receiver.h" -#include "flutter/fml/macros.h" #include "impeller/aiks/canvas_type.h" #include "impeller/aiks/paint.h" diff --git a/engine/src/flutter/impeller/display_list/dl_image_impeller.h b/engine/src/flutter/impeller/display_list/dl_image_impeller.h index 7f590b65474..8f9e51443b0 100644 --- a/engine/src/flutter/impeller/display_list/dl_image_impeller.h +++ b/engine/src/flutter/impeller/display_list/dl_image_impeller.h @@ -5,7 +5,6 @@ #pragma once #include "flutter/display_list/image/dl_image.h" -#include "flutter/fml/macros.h" #include "impeller/core/texture.h" namespace impeller { diff --git a/engine/src/flutter/impeller/display_list/dl_playground.h b/engine/src/flutter/impeller/display_list/dl_playground.h index 476b77b8be2..7b47c364375 100644 --- a/engine/src/flutter/impeller/display_list/dl_playground.h +++ b/engine/src/flutter/impeller/display_list/dl_playground.h @@ -6,7 +6,6 @@ #include "flutter/display_list/display_list.h" #include "flutter/display_list/dl_builder.h" -#include "flutter/fml/macros.h" #include "impeller/playground/playground_test.h" #include "third_party/skia/include/core/SkFont.h" diff --git a/engine/src/flutter/impeller/display_list/nine_patch_converter.h b/engine/src/flutter/impeller/display_list/nine_patch_converter.h index 45caf719df6..44afe97d2fe 100644 --- a/engine/src/flutter/impeller/display_list/nine_patch_converter.h +++ b/engine/src/flutter/impeller/display_list/nine_patch_converter.h @@ -6,12 +6,10 @@ #include -#include "flutter/fml/macros.h" #include "impeller/aiks/canvas_type.h" #include "impeller/aiks/image.h" #include "impeller/aiks/paint.h" #include "impeller/core/sampler_descriptor.h" -#include "impeller/geometry/path.h" namespace impeller { diff --git a/engine/src/flutter/impeller/renderer/backend/metal/formats_mtl.h b/engine/src/flutter/impeller/renderer/backend/metal/formats_mtl.h index 06738ea1b67..95212ce7d68 100644 --- a/engine/src/flutter/impeller/renderer/backend/metal/formats_mtl.h +++ b/engine/src/flutter/impeller/renderer/backend/metal/formats_mtl.h @@ -8,6 +8,7 @@ #include +#include "flutter/fml/build_config.h" #include "flutter/fml/macros.h" #include "impeller/base/validation.h" #include "impeller/core/formats.h" diff --git a/engine/src/flutter/impeller/scene/node.cc b/engine/src/flutter/impeller/scene/node.cc index 8f1da38f1e5..77c090f1353 100644 --- a/engine/src/flutter/impeller/scene/node.cc +++ b/engine/src/flutter/impeller/scene/node.cc @@ -14,6 +14,7 @@ #include "impeller/base/thread.h" #include "impeller/base/validation.h" #include "impeller/geometry/matrix.h" +#include "impeller/image/decompressed_image.h" #include "impeller/scene/animation/animation_player.h" #include "impeller/scene/importer/conversions.h" #include "impeller/scene/importer/scene_flatbuffers.h"