From 6b98f2ca445641a84a5e459621ba899dd6c4e99a Mon Sep 17 00:00:00 2001 From: chunhtai <47866232+chunhtai@users.noreply.github.com> Date: Tue, 29 Nov 2022 16:10:07 -0800 Subject: [PATCH] labeledTapTargetGuideline should passe if textfield does not have label (#116221) --- packages/flutter_test/lib/src/accessibility.dart | 3 ++- packages/flutter_test/test/accessibility_test.dart | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/flutter_test/lib/src/accessibility.dart b/packages/flutter_test/lib/src/accessibility.dart index 32f5a33b662..02fd01a7abd 100644 --- a/packages/flutter_test/lib/src/accessibility.dart +++ b/packages/flutter_test/lib/src/accessibility.dart @@ -219,7 +219,8 @@ class LabeledTapTargetGuideline extends AccessibilityGuideline { }); if (node.isMergedIntoParent || node.isInvisible || - node.hasFlag(ui.SemanticsFlag.isHidden)) { + node.hasFlag(ui.SemanticsFlag.isHidden) || + node.hasFlag(ui.SemanticsFlag.isTextField)) { return result; } final SemanticsData data = node.getSemanticsData(); diff --git a/packages/flutter_test/test/accessibility_test.dart b/packages/flutter_test/test/accessibility_test.dart index 78d4ecf827c..22fc3f307fa 100644 --- a/packages/flutter_test/test/accessibility_test.dart +++ b/packages/flutter_test/test/accessibility_test.dart @@ -874,6 +874,14 @@ void main() { expect(result.passed, true); handle.dispose(); }); + + testWidgets('Passes if text field does not have label', (WidgetTester tester) async { + final SemanticsHandle handle = tester.ensureSemantics(); + await tester.pumpWidget(_boilerplate(const TextField())); + final Evaluation result = await labeledTapTargetGuideline.evaluate(tester); + expect(result.passed, true); + handle.dispose(); + }); }); testWidgets('regression test for material widget',