DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Check that TransformLayer has a finite matrix (flutter/engine#8585)

Browse Source 
To catch issues like https://github.com/flutter/flutter/issues/30586

https://github.com/flutter/flutter/pull/31097 will trigger this CHECK
if https://github.com/flutter/engine/pull/8467 were reverted and the
transform_ were not initialized in this PR.
This commit is contained in:
liyuqian 2019-04-16 20:36:25 -07:00 committed by GitHub
parent 922d6df36f
commit 6a28ed4830
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
engine/src/flutter/flow/layers/transform_layer.cc
View File

@ -6,11 +6,27 @@
namespace flow {
TransformLayer::TransformLayer() = default;
TransformLayer::TransformLayer() {
transform_.setIdentity();
}
TransformLayer::~TransformLayer() = default;
void TransformLayer::Preroll(PrerollContext* context, const SkMatrix& matrix) {
// Checks (in some degree) that SkMatrix transform_ is valid and initialized.
//
// We need this even if is_set_ is true since one can call set_transform with
// an uninitialized SkMatrix.
//
// If transform_ is uninitialized, this assert may look flaky as it doesn't
// fail all the time, and some rerun may make it pass. But don't ignore it and
// just rerun the test if this is triggered, since even a flaky failure here
// may signify a potentially big problem in the code.
//
// We have to write this flaky test because there is no reliable way to test
// whether a variable is initialized or not in C++.
FML_CHECK(transform_.isFinite());
SkMatrix child_matrix;
child_matrix.setConcat(matrix, transform_);