DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Show warning if method response errors occur and error not handled. (flutter/engine#18946)

Browse Source
This commit is contained in:
Robert Ancell 2020-06-12 09:11:36 +12:00 committed by GitHub
parent 7c73569ad4
commit 67fc8be0e6
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
engine/src/flutter/shell/platform/linux/fl_method_call.cc
View File

@ -79,8 +79,22 @@ G_MODULE_EXPORT gboolean fl_method_call_respond(FlMethodCall* self,
GError** error) {
g_return_val_if_fail(FL_IS_METHOD_CALL(self), FALSE);
g_return_val_if_fail(FL_IS_METHOD_RESPONSE(response), FALSE);
return fl_method_channel_respond(self->channel, self->response_handle,
response, error);
g_autoptr(GError) local_error = nullptr;
if (!fl_method_channel_respond(self->channel, self->response_handle, response,
&local_error)) {
// If the developer chose not to handle the error then log it so it's not
// missed.
if (error == nullptr) {
g_warning("Failed to send method call response: %s",
local_error->message);
}
g_propagate_error(error, local_error);
return FALSE;
}
return TRUE;
}
G_MODULE_EXPORT gboolean fl_method_call_respond_success(FlMethodCall* self,