DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

cancel open subscription (#5824)

Browse Source 
fixes https://github.com/flutter/flutter/issues/5788
This commit is contained in:
Dan Rubel 2016-09-12 16:32:08 -04:00 committed by GitHub
parent 4ea8f302ab
commit 678da3ac2b
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.analysis_options
View File

@ -38,7 +38,7 @@ linter:
# === error rules ===
- avoid_empty_else
# - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
# - cancel_subscriptions # https://github.com/flutter/flutter/issues/5788
- cancel_subscriptions
# - close_sinks # https://github.com/flutter/flutter/issues/5789
- control_flow_in_finally
- empty_statements

2
.analysis_options_flutter_analyze
View File

@ -39,7 +39,7 @@ linter:
# === error rules ===
- avoid_empty_else
# - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
# - cancel_subscriptions # https://github.com/flutter/flutter/issues/5788
- cancel_subscriptions
# - close_sinks # https://github.com/flutter/flutter/issues/5789
- control_flow_in_finally
- empty_statements

1
packages/flutter_tools/lib/src/base/process.dart
View File

@ -78,6 +78,7 @@ Future<int> runCommandAndStreamOutput(List<String> cmd, {
// Wait for stdout to be fully processed
// because process.exitCode may complete first causing flaky tests.
await subscription.asFuture();
subscription.cancel();
return await process.exitCode;
}