From 6494dde3645ec1c281e431aab89375ca01e3142f Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Tue, 6 Feb 2018 15:54:10 -0800 Subject: [PATCH] Apply media padding in Gallery Shrine demo (#14506) Applies horizontal and bottom safe area insets to the Shrine demo in the Gallery. Top insets are not applied due to the presence of the omnipresent sliver app bar. Specifically, this ensures that the grid cards are inset inside the iPhone X notch in horizontal mode, and that the bottom of the grid is positioned above the iOS home indicator. --- .../flutter_gallery/lib/demo/shrine/shrine_home.dart | 9 ++++----- .../flutter_gallery/lib/demo/shrine/shrine_order.dart | 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/flutter_gallery/lib/demo/shrine/shrine_home.dart b/examples/flutter_gallery/lib/demo/shrine/shrine_home.dart index 80d16d42292..c1fbffc0386 100644 --- a/examples/flutter_gallery/lib/demo/shrine/shrine_home.dart +++ b/examples/flutter_gallery/lib/demo/shrine/shrine_home.dart @@ -388,11 +388,10 @@ class _ShrineHomeState extends State { shoppingCart: _shoppingCart, body: new CustomScrollView( slivers: [ - new SliverToBoxAdapter( - child: new _Heading(product: featured), - ), - new SliverPadding( - padding: const EdgeInsets.all(16.0), + new SliverToBoxAdapter(child: new _Heading(product: featured)), + new SliverSafeArea( + top: false, + minimum: const EdgeInsets.all(16.0), sliver: new SliverGrid( gridDelegate: gridDelegate, delegate: new SliverChildListDelegate( diff --git a/examples/flutter_gallery/lib/demo/shrine/shrine_order.dart b/examples/flutter_gallery/lib/demo/shrine/shrine_order.dart index 05a08e1c863..13f3d44a79b 100644 --- a/examples/flutter_gallery/lib/demo/shrine/shrine_order.dart +++ b/examples/flutter_gallery/lib/demo/shrine/shrine_order.dart @@ -287,8 +287,9 @@ class _OrderPageState extends State { quantityChanged: (int value) { updateOrder(quantity: value); }, ), ), - new SliverPadding( - padding: const EdgeInsets.fromLTRB(8.0, 32.0, 8.0, 8.0), + new SliverSafeArea( + top: false, + minimum: const EdgeInsets.fromLTRB(8.0, 32.0, 8.0, 8.0), sliver: new SliverGrid( gridDelegate: const SliverGridDelegateWithMaxCrossAxisExtent( maxCrossAxisExtent: 248.0,