From 635a109a6d44aed3a5a906d130d23d99ebb3ee71 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Thu, 22 Jun 2023 10:17:48 -0700 Subject: [PATCH] [Impeller] Add fence waiter trace event. (flutter/engine#43092) I suspect that some of the worst frame times are caused by submission blocking on adding a fence. Add a trace event that would make that obvious. ![unnamed](https://github.com/flutter/engine/assets/8975114/93650ac8-4451-49d7-b8fa-00fc9f7f4277) --- .../flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc b/engine/src/flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc index 4c5d27f95e9..7e4c1361a28 100644 --- a/engine/src/flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc +++ b/engine/src/flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc @@ -30,6 +30,7 @@ bool FenceWaiterVK::IsValid() const { bool FenceWaiterVK::AddFence(vk::UniqueFence fence, const fml::closure& callback) { + TRACE_EVENT0("flutter", "FenceWaiterVK::AddFence"); if (!IsValid() || !fence || !callback) { return false; }