diff --git a/dev/automated_tests/pubspec.yaml b/dev/automated_tests/pubspec.yaml index a76769da5bc..5f4288f8a7e 100644 --- a/dev/automated_tests/pubspec.yaml +++ b/dev/automated_tests/pubspec.yaml @@ -1,5 +1,11 @@ name: flutter_automated_tests dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter flutter_test: diff --git a/dev/benchmarks/complex_layout/pubspec.yaml b/dev/benchmarks/complex_layout/pubspec.yaml index 8e3f79a49d7..59c3ebebcf0 100644 --- a/dev/benchmarks/complex_layout/pubspec.yaml +++ b/dev/benchmarks/complex_layout/pubspec.yaml @@ -2,6 +2,12 @@ name: complex_layout description: A new flutter project. dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter flutter_driver: diff --git a/dev/benchmarks/microbenchmarks/pubspec.yaml b/dev/benchmarks/microbenchmarks/pubspec.yaml index 007fc940bfe..15319a20213 100644 --- a/dev/benchmarks/microbenchmarks/pubspec.yaml +++ b/dev/benchmarks/microbenchmarks/pubspec.yaml @@ -1,6 +1,12 @@ name: microbenchmarks description: A new flutter project. dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter flutter_test: diff --git a/dev/devicelab/pubspec.yaml b/dev/devicelab/pubspec.yaml index 013912f859f..2126ea8291f 100644 --- a/dev/devicelab/pubspec.yaml +++ b/dev/devicelab/pubspec.yaml @@ -8,7 +8,12 @@ environment: sdk: '>=1.12.0 <2.0.0' dependencies: - args: ^0.13.4 + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + meta: ^1.0.3 path: ^1.3.0 stack_trace: ^1.4.0 diff --git a/dev/manual_tests/pubspec.yaml b/dev/manual_tests/pubspec.yaml index 026ef9e8a6c..a1f49a5cb70 100644 --- a/dev/manual_tests/pubspec.yaml +++ b/dev/manual_tests/pubspec.yaml @@ -1,6 +1,12 @@ name: flutter_manual_tests dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter diff --git a/dev/tools/pubspec.yaml b/dev/tools/pubspec.yaml index 87f23b4eb5a..62febc511f0 100644 --- a/dev/tools/pubspec.yaml +++ b/dev/tools/pubspec.yaml @@ -2,5 +2,10 @@ name: dev_tools description: Various repository development tools for flutter. dependencies: - args: ^0.13.4 + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + path: ^1.3.0 diff --git a/examples/flutter_gallery/pubspec.yaml b/examples/flutter_gallery/pubspec.yaml index b8128aa7991..4fc5f471b53 100644 --- a/examples/flutter_gallery/pubspec.yaml +++ b/examples/flutter_gallery/pubspec.yaml @@ -1,5 +1,11 @@ name: flutter_gallery dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + collection: '>=1.9.1 <2.0.0' intl: '>=0.14.0 <0.15.0' string_scanner: ^1.0.0 diff --git a/examples/hello_services/pubspec.yaml b/examples/hello_services/pubspec.yaml index 16e9afc35c9..7472d21a248 100644 --- a/examples/hello_services/pubspec.yaml +++ b/examples/hello_services/pubspec.yaml @@ -1,6 +1,12 @@ name: hello_services dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter diff --git a/examples/hello_world/pubspec.yaml b/examples/hello_world/pubspec.yaml index 0588b4ed332..8be6c8cfe5e 100644 --- a/examples/hello_world/pubspec.yaml +++ b/examples/hello_world/pubspec.yaml @@ -1,6 +1,12 @@ name: hello_world dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter diff --git a/examples/layers/pubspec.yaml b/examples/layers/pubspec.yaml index c88f60fac25..3c8c1cd9f4a 100644 --- a/examples/layers/pubspec.yaml +++ b/examples/layers/pubspec.yaml @@ -1,5 +1,11 @@ name: flutter_examples_layers dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter diff --git a/examples/stocks/pubspec.yaml b/examples/stocks/pubspec.yaml index 471dad272bb..caeb30d3233 100644 --- a/examples/stocks/pubspec.yaml +++ b/examples/stocks/pubspec.yaml @@ -1,5 +1,11 @@ name: stocks dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter intl: '>=0.14.0 <0.15.0' diff --git a/packages/flutter/pubspec.yaml b/packages/flutter/pubspec.yaml index ef53fcc37c9..1ebb32c27b1 100644 --- a/packages/flutter/pubspec.yaml +++ b/packages/flutter/pubspec.yaml @@ -5,6 +5,12 @@ description: A framework for writing Flutter applications homepage: http://flutter.io dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + collection: '>=1.9.1 <2.0.0' intl: '>=0.14.0 <0.15.0' meta: ^1.0.3 diff --git a/packages/flutter_driver/pubspec.yaml b/packages/flutter_driver/pubspec.yaml index bb5a6240476..23563e195d1 100644 --- a/packages/flutter_driver/pubspec.yaml +++ b/packages/flutter_driver/pubspec.yaml @@ -8,6 +8,12 @@ environment: sdk: '>=1.19.0 <2.0.0' dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + file: '^0.1.0' json_rpc_2: '^2.0.0' matcher: '>=0.12.0 <1.0.0' diff --git a/packages/flutter_markdown/pubspec.yaml b/packages/flutter_markdown/pubspec.yaml index fb171221188..55f609492e2 100644 --- a/packages/flutter_markdown/pubspec.yaml +++ b/packages/flutter_markdown/pubspec.yaml @@ -5,6 +5,12 @@ author: Flutter Authors homepage: http://flutter.io dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + flutter: sdk: flutter markdown: '^0.9.0' diff --git a/packages/flutter_test/pubspec.yaml b/packages/flutter_test/pubspec.yaml index a78ab3c7c46..b063d5d9954 100644 --- a/packages/flutter_test/pubspec.yaml +++ b/packages/flutter_test/pubspec.yaml @@ -1,5 +1,11 @@ name: flutter_test dependencies: + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + quiver: ^0.21.4 # The flutter tools depend on very specific internal implementation diff --git a/packages/flutter_tools/lib/executable.dart b/packages/flutter_tools/lib/executable.dart index ac852ac892a..bdcfc302910 100644 --- a/packages/flutter_tools/lib/executable.dart +++ b/packages/flutter_tools/lib/executable.dart @@ -86,7 +86,7 @@ Future main(List args) async { Doctor.initGlobal(); dynamic result = await runner.run(args); - _exit(result is int ? result : 0); + _exit(result is int ? result : 1); }, onError: (dynamic error, Chain chain) { if (error is UsageException) { stderr.writeln(error.message); diff --git a/packages/flutter_tools/pubspec.yaml b/packages/flutter_tools/pubspec.yaml index b716b7dda51..7b867fb4ae3 100644 --- a/packages/flutter_tools/pubspec.yaml +++ b/packages/flutter_tools/pubspec.yaml @@ -9,7 +9,12 @@ environment: dependencies: archive: ^1.0.20 - args: ^0.13.4 + + # version 0.13.6+1 does not return the value from the command + # causing flutter tools to always have exit code 0 + # see https://github.com/flutter/flutter/issues/6766 + args: 0.13.6 + coverage: ^0.8.0 crypto: '>=1.1.1 <3.0.0' file: ^0.1.0