DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make _RenderButtonBarRow.constraints null aware (#57261)

Browse Source
This commit is contained in:
Andre 2020-05-18 12:07:02 -04:00 committed by GitHub
parent f2c12d7e79
commit 6294dd59bb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/button_bar.dart
View File

@ -334,7 +334,7 @@ class _RenderButtonBarRow extends RenderFlex {
BoxConstraints get constraints {
if (_hasCheckedLayoutWidth)
return super.constraints;
return super.constraints.copyWith(maxWidth: double.infinity);
return super.constraints?.copyWith(maxWidth: double.infinity);
}
@override

14
packages/flutter/test/material/button_bar_test.dart
View File

@ -627,4 +627,18 @@ void main() {
},
);
});
testWidgets('_RenderButtonBarRow.constraints works before layout', (WidgetTester tester) async {
await tester.pumpWidget(
const MaterialApp(home: ButtonBar()),
Duration.zero,
EnginePhase.build,
);
final Finder buttonBar = find.byWidgetPredicate((Widget w) => '${w.runtimeType}' == '_ButtonBarRow');
final RenderBox renderButtonBar = tester.renderObject(buttonBar) as RenderBox;
expect(renderButtonBar.debugNeedsLayout, isTrue);
expect(renderButtonBar.constraints, isNull);
});
}