DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2507 from abarth/less_core

Browse Source 
Don't dump core on startup exceptions
This commit is contained in:
Adam Barth 2016-03-15 14:30:11 -07:00
commit 5e68565d71
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sky/engine/core/script/dart_controller.cc
View File

@ -83,7 +83,8 @@ bool DartController::SendStartMessage(Dart_Handle root_library) {
ToDart("_getMainClosure"),
0,
NULL);
DART_CHECK_VALID(main_closure);
if (LogIfError(main_closure))
return true;
// Send the start message containing the entry point by calling
// _startMainIsolate in dart:isolate.
@ -122,8 +123,9 @@ void DartController::DidLoadSnapshot() {
DartApiScope dart_api_scope;
Dart_Handle library = Dart_RootLibrary();
if (LogIfError(library))
return;
SendStartMessage(library);
exit(1);
if (SendStartMessage(library))
exit(1);
}
void DartController::RunFromPrecompiledSnapshot() {
@ -143,8 +145,9 @@ void DartController::RunFromSnapshotBuffer(const uint8_t* buffer, size_t size) {
LogIfError(Dart_LoadScriptFromSnapshot(buffer, size));
Dart_Handle library = Dart_RootLibrary();
if (LogIfError(library))
return;
SendStartMessage(library);
exit(1);
if (SendStartMessage(library))
exit(1);
}
void DartController::RunFromLibrary(const std::string& name,