From 5dfa50c8381082c1becd03bf76da4aba95c0acaa Mon Sep 17 00:00:00 2001 From: Casey Hillers Date: Mon, 3 Oct 2022 06:24:22 -0700 Subject: [PATCH] Revert "Add button semantics in list tile" (#112779) --- packages/flutter/lib/src/material/list_tile.dart | 1 - packages/flutter/test/material/list_tile_test.dart | 1 - packages/flutter/test/material/radio_list_tile_test.dart | 2 -- packages/flutter/test/material/reorderable_list_test.dart | 1 - packages/flutter/test/material/switch_list_tile_test.dart | 3 --- 5 files changed, 8 deletions(-) diff --git a/packages/flutter/lib/src/material/list_tile.dart b/packages/flutter/lib/src/material/list_tile.dart index 03df36a69f2..2e796c0c05a 100644 --- a/packages/flutter/lib/src/material/list_tile.dart +++ b/packages/flutter/lib/src/material/list_tile.dart @@ -747,7 +747,6 @@ class ListTile extends StatelessWidget { autofocus: autofocus, enableFeedback: enableFeedback ?? tileTheme.enableFeedback ?? true, child: Semantics( - button: onTap != null, selected: selected, enabled: enabled, child: Ink( diff --git a/packages/flutter/test/material/list_tile_test.dart b/packages/flutter/test/material/list_tile_test.dart index 3d19c0cb3e0..2066f784d82 100644 --- a/packages/flutter/test/material/list_tile_test.dart +++ b/packages/flutter/test/material/list_tile_test.dart @@ -325,7 +325,6 @@ void main() { ), TestSemantics.rootChild( flags: [ - SemanticsFlag.isButton, SemanticsFlag.hasEnabledState, SemanticsFlag.isEnabled, SemanticsFlag.isFocusable, diff --git a/packages/flutter/test/material/radio_list_tile_test.dart b/packages/flutter/test/material/radio_list_tile_test.dart index 38a8b33551e..02a181ed209 100644 --- a/packages/flutter/test/material/radio_list_tile_test.dart +++ b/packages/flutter/test/material/radio_list_tile_test.dart @@ -407,7 +407,6 @@ void main() { SemanticsFlag.hasCheckedState, SemanticsFlag.hasEnabledState, SemanticsFlag.isEnabled, - SemanticsFlag.isButton, SemanticsFlag.isInMutuallyExclusiveGroup, SemanticsFlag.isFocusable, ], @@ -445,7 +444,6 @@ void main() { SemanticsFlag.isChecked, SemanticsFlag.hasEnabledState, SemanticsFlag.isEnabled, - SemanticsFlag.isButton, SemanticsFlag.isInMutuallyExclusiveGroup, SemanticsFlag.isFocusable, ], diff --git a/packages/flutter/test/material/reorderable_list_test.dart b/packages/flutter/test/material/reorderable_list_test.dart index 4ed5c01e3e7..e42967c7031 100644 --- a/packages/flutter/test/material/reorderable_list_test.dart +++ b/packages/flutter/test/material/reorderable_list_test.dart @@ -677,7 +677,6 @@ void main() { hasToggledState: true, isToggled: true, isEnabled: true, - isButton: true, isFocusable: true, hasEnabledState: true, label: 'Switch tile', diff --git a/packages/flutter/test/material/switch_list_tile_test.dart b/packages/flutter/test/material/switch_list_tile_test.dart index ff97cf13fb4..aa732eb03be 100644 --- a/packages/flutter/test/material/switch_list_tile_test.dart +++ b/packages/flutter/test/material/switch_list_tile_test.dart @@ -76,7 +76,6 @@ void main() { SemanticsFlag.hasEnabledState, SemanticsFlag.hasToggledState, SemanticsFlag.isEnabled, - SemanticsFlag.isButton, SemanticsFlag.isFocusable, SemanticsFlag.isToggled, ], @@ -92,7 +91,6 @@ void main() { SemanticsFlag.hasEnabledState, SemanticsFlag.isChecked, SemanticsFlag.isEnabled, - SemanticsFlag.isButton, SemanticsFlag.isFocusable, ], actions: SemanticsAction.tap.index, @@ -106,7 +104,6 @@ void main() { SemanticsFlag.hasCheckedState, SemanticsFlag.hasEnabledState, SemanticsFlag.isEnabled, - SemanticsFlag.isButton, SemanticsFlag.isFocusable, SemanticsFlag.isInMutuallyExclusiveGroup, ],