DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avg ms/frame instead of FPS in performance overlay (#7443)

Browse Source 
Computing FPS from max ms/frame is misleading and we're no longer
just using 60 FPS displays.
This commit is contained in:
liyuqian 2019-01-15 07:16:24 +08:00 committed by GitHub
parent b7e0527982
commit 5ce5ace6ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
flow/instrumentation.cc
View File

@ -63,6 +63,14 @@ fml::TimeDelta Stopwatch::MaxDelta() const {
return max_delta;
}
fml::TimeDelta Stopwatch::AverageDelta() const {
fml::TimeDelta sum; // default to 0
for (size_t i = 0; i < kMaxSamples; i++) {
sum = sum + laps_[i];
}
return sum / kMaxSamples;
}
// Initialize the SkSurface for drawing into. Draws the base background and any
// timing data from before the initial Visualize() call.
void Stopwatch::InitVisualizeSurface(const SkRect& rect) const {

4
flow/instrumentation.h
View File

@ -14,6 +14,8 @@
namespace flow {
// DEPRECATED
// The frame per second FPS could be different than 60 (e.g., 120).
static const double kOneFrameMS = 1e3 / 60.0;
class Stopwatch {
@ -28,6 +30,8 @@ class Stopwatch {
fml::TimeDelta MaxDelta() const;
fml::TimeDelta AverageDelta() const;
void InitVisualizeSurface(const SkRect& rect) const;
void Visualize(SkCanvas& canvas, const SkRect& rect) const;

15
flow/layers/performance_overlay_layer.cc
View File

@ -43,19 +43,14 @@ void VisualizeStopWatch(SkCanvas& canvas,
}
if (show_labels) {
double ms_per_frame = stopwatch.MaxDelta().ToMillisecondsF();
double fps;
if (ms_per_frame < kOneFrameMS) {
fps = 1e3 / kOneFrameMS;
} else {
fps = 1e3 / ms_per_frame;
}
double max_ms_per_frame = stopwatch.MaxDelta().ToMillisecondsF();
double average_ms_per_frame = stopwatch.AverageDelta().ToMillisecondsF();
std::stringstream stream;
stream.setf(std::ios::fixed | std::ios::showpoint);
stream << std::setprecision(1);
stream << label_prefix << " " << fps << " fps " << ms_per_frame
<< "ms/frame";
stream << label_prefix << " "
<< "max " << max_ms_per_frame << " ms/frame, "
<< "avg " << average_ms_per_frame << " ms/frame";
DrawStatisticsText(canvas, stream.str(), x + label_x, y + height + label_y);
}
}