From 5c8b028bd36b3854c073531939c8aa2a1b9230da Mon Sep 17 00:00:00 2001 From: Viet-Trung Luu Date: Wed, 24 Jun 2015 15:24:01 -0700 Subject: [PATCH] Don't use base::WorkerPool in the asset_bundle app. WorkerPools can't be shut down, which means that the app's .so can't be unloaded (which is bad for single process mode, and which is probably why the asset bundle tests are flakily crashing on the try bots). So use a SequencedWorkerPool instead (even though we don't care about sequencing). R=eseidel@chromium.org, kulakowski@chromium.org, abarth@chromium.org BUG=Fixes #268 Review URL: https://codereview.chromium.org/1206673006. --- engine/src/flutter/shell/ui/internals.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/shell/ui/internals.cc b/engine/src/flutter/shell/ui/internals.cc index 7d65380053c..96950997f0b 100644 --- a/engine/src/flutter/shell/ui/internals.cc +++ b/engine/src/flutter/shell/ui/internals.cc @@ -4,6 +4,7 @@ #include "sky/shell/ui/internals.h" +#include "base/threading/worker_pool.h" #include "mojo/public/cpp/application/connect.h" #include "mojo/public/cpp/bindings/array.h" #include "services/asset_bundle/asset_unpacker_impl.h" @@ -107,7 +108,8 @@ Internals::~Internals() { void Internals::Create( mojo::ApplicationConnection* connection, mojo::InterfaceRequest request) { - new mojo::asset_bundle::AssetUnpackerImpl(request.Pass()); + new mojo::asset_bundle::AssetUnpackerImpl( + request.Pass(), base::WorkerPool::GetTaskRunner(true)); } mojo::Handle Internals::TakeServicesProvidedByEmbedder() {