From 5a9063f55cbd8a9dc0225a09eadfc00e761c6cdb Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Wed, 11 Jan 2017 10:36:37 -0800 Subject: [PATCH] Remove waitForElement-specific timeout. (#7442) It is now handled at a higher level for all commands. --- packages/flutter_driver/lib/src/extension.dart | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/flutter_driver/lib/src/extension.dart b/packages/flutter_driver/lib/src/extension.dart index ebf99dddd7d..74495eaadc8 100644 --- a/packages/flutter_driver/lib/src/extension.dart +++ b/packages/flutter_driver/lib/src/extension.dart @@ -21,7 +21,6 @@ import 'render_tree.dart'; const String _extensionMethodName = 'driver'; const String _extensionMethod = 'ext.flutter.$_extensionMethodName'; -const Duration _kDefaultTimeout = const Duration(seconds: 5); class _DriverBinding extends WidgetsFlutterBinding { // TODO(ianh): refactor so we're not extending a concrete binding @override @@ -156,9 +155,7 @@ class _FlutterDriverExtension { return new RenderTree(RendererBinding.instance?.renderView?.toStringDeep()); } - /// Runs `finder` repeatedly until it finds one or more [Element]s, or times out. - /// - /// The timeout is five seconds. + /// Runs `finder` repeatedly until it finds one or more [Element]s. Future _waitForElement(Finder finder) { // Short-circuit if the element is already on the UI if (finder.precache()) @@ -168,15 +165,9 @@ class _FlutterDriverExtension { Completer completer = new Completer(); StreamSubscription subscription; - Timer timeout = new Timer(_kDefaultTimeout, () { - subscription.cancel(); - completer.completeError('Timed out waiting for ${finder.description}'); - }); - subscription = _onFrameReady.listen((Duration duration) { if (finder.precache()) { subscription.cancel(); - timeout.cancel(); completer.complete(finder); } });