DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] Add test that "Unresolve URI" warnings from DWDS are filtered from logs (#102399)

Browse Source
This commit is contained in:
Christopher Fujino 2022-04-22 15:29:07 -07:00 committed by GitHub
parent a3a9a23e46
commit 5a3e10047f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/flutter_tools/lib/src/isolated/devfs_web.dart
View File

@ -275,7 +275,7 @@ class WebAssetServer implements AssetReader {
}
logging.Logger.root.level = logging.Level.ALL;
logging.Logger.root.onRecord.listen(_log);
logging.Logger.root.onRecord.listen(log);
// In debug builds, spin up DWDS and the full asset server.
final Dwds dwds = await dwdsLauncher(
@ -1004,7 +1004,8 @@ class ReleaseAssetServer {
}
}
void _log(logging.LogRecord event) {
@visibleForTesting
void log(logging.LogRecord event) {
final String error = event.error == null? '': 'Error: ${event.error}';
if (event.level >= logging.Level.SEVERE) {
globals.printError('${event.loggerName}: ${event.message}$error', stackTrace: event.stackTrace);

30
packages/flutter_tools/test/general.shard/web/devfs_web_test.dart
View File

@ -8,6 +8,7 @@ import 'dart:io' hide Directory, File;
import 'package:flutter_tools/src/artifacts.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/logger.dart';
import 'package:flutter_tools/src/base/platform.dart';
import 'package:flutter_tools/src/build_info.dart';
import 'package:flutter_tools/src/build_system/targets/web.dart';
@ -16,6 +17,7 @@ import 'package:flutter_tools/src/convert.dart';
import 'package:flutter_tools/src/globals.dart' as globals;
import 'package:flutter_tools/src/isolated/devfs_web.dart';
import 'package:flutter_tools/src/web/compile.dart';
import 'package:logging/logging.dart' as logging;
import 'package:package_config/package_config.dart';
import 'package:shelf/shelf.dart';
import 'package:test/fake.dart';
@ -39,6 +41,7 @@ void main() {
PackageConfig packages;
Platform windows;
FakeHttpServer httpServer;
BufferLogger logger;
setUpAll(() async {
packages = PackageConfig(<Package>[
@ -50,6 +53,7 @@ void main() {
httpServer = FakeHttpServer();
linux = FakePlatform(environment: <String, String>{});
windows = FakePlatform(operatingSystem: 'windows', environment: <String, String>{});
logger = BufferLogger.test();
testbed = Testbed(setup: () {
webAssetServer = WebAssetServer(
httpServer,
@ -67,9 +71,35 @@ void main() {
webBuildDirectory: null,
basePath: null,
);
}, overrides: <Type, Generator>{
Logger: () => logger,
});
});
test('.log() filters events', () => testbed.run(() {
// harmless warning that should be filtered out
const String harmlessMessage = 'Unresolved uri: dart:ui';
// serious warning
const String seriousMessage = 'Something bad happened';
final List<logging.LogRecord> events = <logging.LogRecord>[
logging.LogRecord(
logging.Level.WARNING,
harmlessMessage,
'DartUri',
),
logging.LogRecord(
logging.Level.WARNING,
seriousMessage,
'DartUri',
),
];
events.forEach(log);
expect(logger.warningText, contains(seriousMessage));
expect(logger.warningText, isNot(contains(harmlessMessage)));
}));
test('Handles against malformed manifest', () => testbed.run(() async {
final File source = globals.fs.file('source')
..writeAsStringSync('main() {}');