From 589dd8028b055bef808fa02ee62d5d13d4a80e98 Mon Sep 17 00:00:00 2001 From: Christopher Fujino Date: Wed, 15 Jun 2022 16:22:06 -0700 Subject: [PATCH] [flutter_tools] print override storage warning to STDERR instead of STDOUT (#106068) --- packages/flutter_tools/lib/src/cache.dart | 2 +- .../test/general.shard/cache_test.dart | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/packages/flutter_tools/lib/src/cache.dart b/packages/flutter_tools/lib/src/cache.dart index 6fe426a5601..6d4db333cef 100644 --- a/packages/flutter_tools/lib/src/cache.dart +++ b/packages/flutter_tools/lib/src/cache.dart @@ -520,7 +520,7 @@ class Cache { if (_hasWarnedAboutStorageOverride) { return; } - _logger.printStatus( + _logger.printError( 'Flutter assets will be downloaded from $overrideUrl. Make sure you trust this source!', emphasis: true, ); diff --git a/packages/flutter_tools/test/general.shard/cache_test.dart b/packages/flutter_tools/test/general.shard/cache_test.dart index 473552687b7..85b46371ad6 100644 --- a/packages/flutter_tools/test/general.shard/cache_test.dart +++ b/packages/flutter_tools/test/general.shard/cache_test.dart @@ -319,6 +319,22 @@ void main() { expect(() => cache.storageBaseUrl, throwsToolExit()); }); + + testWithoutContext('overridden storage base url prints warning to STDERR', () async { + final BufferLogger logger = BufferLogger.test(); + const String baseUrl = 'https://storage.com'; + final Cache cache = Cache.test( + platform: FakePlatform(environment: { + 'FLUTTER_STORAGE_BASE_URL': baseUrl, + }), + processManager: FakeProcessManager.any(), + logger: logger, + ); + + expect(cache.storageBaseUrl, baseUrl); + expect(logger.errorText, contains('Flutter assets will be downloaded from $baseUrl')); + expect(logger.statusText, isEmpty); + }); }); testWithoutContext('flattenNameSubdirs', () {