From 581afe50aa1015fbeda97a7fa53b4fe014e4e3df Mon Sep 17 00:00:00 2001 From: Alexander Biggs Date: Sat, 11 Jun 2022 15:43:05 -0400 Subject: [PATCH] [fuchsia] Stop unimplemented TextInput from log spamming. (flutter/engine#33811) --- .../shell/platform/fuchsia/flutter/platform_view.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/engine/src/flutter/shell/platform/fuchsia/flutter/platform_view.cc b/engine/src/flutter/shell/platform/fuchsia/flutter/platform_view.cc index 1ff88686fc7..4f9a05d1e80 100644 --- a/engine/src/flutter/shell/platform/fuchsia/flutter/platform_view.cc +++ b/engine/src/flutter/shell/platform/fuchsia/flutter/platform_view.cc @@ -661,6 +661,16 @@ bool PlatformView::HandleFlutterTextInputChannelPlatformMessage( current_text_input_client_ = 0; last_text_state_ = nullptr; DeactivateIme(); + } else if (method->value == "TextInput.setCaretRect" || + method->value == "TextInput.setEditableSizeAndTransform" || + method->value == "TextInput.setMarkedTextRect" || + method->value == "TextInput.setStyle") { + // We don't have these methods implemented and they get + // sent a lot during text input, so we create an empty case for them + // here to avoid "Unknown flutter/textinput method TextInput.*" + // log spam. + // + // TODO(fxb/101619): We should implement these. } else { FML_LOG(ERROR) << "Unknown " << message->channel() << " method " << method->value.GetString();