From 55ed56040df994a6f2bb7141d83035e41499e1ca Mon Sep 17 00:00:00 2001
From: Chinmay Garde <chinmaygarde@gmail.com>
Date: Wed, 23 Nov 2016 16:12:39 -0800
Subject: [PATCH] Add testonly = true to the flutter/testing target and disable
 WTF tests that depend on ICU. (#3271)

---
 sky/engine/wtf/BUILD.gn  | 7 +++++--
 synchronization/BUILD.gn | 2 ++
 testing/BUILD.gn         | 2 ++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/sky/engine/wtf/BUILD.gn b/sky/engine/wtf/BUILD.gn
index a399a1bb371..fb4b55d3cf4 100644
--- a/sky/engine/wtf/BUILD.gn
+++ b/sky/engine/wtf/BUILD.gn
@@ -237,10 +237,13 @@ executable("wtf_unittests") {
     "text/StringBuilderTest.cpp",
     "text/StringImplTest.cpp",
     "text/StringOperatorsTest.cpp",
-    "text/TextCodecReplacementTest.cpp",
     "text/TextCodecUTF8Test.cpp",
-    "text/WTFStringTest.cpp",
     "VectorTest.cpp",
+
+    # The following tests depend on either ICU or the locale. Disable them for
+    # now.
+    # "text/TextCodecReplacementTest.cpp",
+    # "text/WTFStringTest.cpp",
   ]
 
   configs += [
diff --git a/synchronization/BUILD.gn b/synchronization/BUILD.gn
index f75e6996bea..387cd3447f6 100644
--- a/synchronization/BUILD.gn
+++ b/synchronization/BUILD.gn
@@ -18,6 +18,8 @@ source_set("synchronization") {
 }
 
 executable("synchronization_unittests") {
+  testonly = true
+
   sources = [
     "semaphore_unittest.cc",
   ]
diff --git a/testing/BUILD.gn b/testing/BUILD.gn
index 03310b61828..0740ad43876 100644
--- a/testing/BUILD.gn
+++ b/testing/BUILD.gn
@@ -3,6 +3,8 @@
 # found in the LICENSE file.
 
 source_set("testing") {
+  testonly = true
+
   sources = [
     "//flutter/testing/run_all_unittests.cc",
   ]