From 554e637a35beef3e9bc7c882f2f6a322a415b6b6 Mon Sep 17 00:00:00 2001 From: Srujan Gaddam <58529443+srujzs@users.noreply.github.com> Date: Wed, 26 Jun 2024 09:32:08 -0700 Subject: [PATCH] Ignore lints that will be triggered by ExternalDartReference changes (flutter/engine#53572) https://dart-review.googlesource.com/c/sdk/+/370663 makes ExternalDartReference generic. By doing so, it triggers two cast_nullable_to_non_nullable lints that need to be silenced for it to land. Once the above SDK changes land, this can be refactored to utilize the generic and avoid the manual cast altogether. --- .../lib/web_ui/lib/src/engine/canvaskit/native_memory.dart | 1 + .../lib/web_ui/lib/src/engine/skwasm/skwasm_impl/memory.dart | 1 + 2 files changed, 2 insertions(+) diff --git a/engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/native_memory.dart b/engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/native_memory.dart index 8af6b3aaa55..4caf251c031 100644 --- a/engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/native_memory.dart +++ b/engine/src/flutter/lib/web_ui/lib/src/engine/canvaskit/native_memory.dart @@ -22,6 +22,7 @@ import 'package:ui/src/engine.dart'; /// 6. We call `delete` on SkPaint. DomFinalizationRegistry _finalizationRegistry = DomFinalizationRegistry( (ExternalDartReference boxedUniq) { + // ignore: cast_nullable_to_non_nullable final UniqueRef uniq = boxedUniq.toDartObject as UniqueRef; uniq.collect(); }.toJS diff --git a/engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_impl/memory.dart b/engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_impl/memory.dart index ef60ac0ae7c..d6d739c7376 100644 --- a/engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_impl/memory.dart +++ b/engine/src/flutter/lib/web_ui/lib/src/engine/skwasm/skwasm_impl/memory.dart @@ -29,6 +29,7 @@ typedef DisposeFunction = void Function(Pointer); class SkwasmFinalizationRegistry { SkwasmFinalizationRegistry(this.dispose) : registry = DomFinalizationRegistry(((ExternalDartReference address) => + // ignore: cast_nullable_to_non_nullable dispose(Pointer.fromAddress(address.toDartObject as int)) ).toJS);