DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add didSendFirstFrameEvent service extension. (#25977)

Browse Source 
* Add didSendFirstFrameEvent service extension.
This commit is contained in:
Kenzie Schmoll 2019-01-03 10:38:06 -08:00 committed by GitHub
parent 71be92e68e
commit 52e5cd24dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/flutter/lib/src/widgets/binding.dart
View File

@ -289,6 +289,15 @@ mixin WidgetsBinding on BindingBase, SchedulerBinding, GestureBinding, RendererB
return _forceRebuild();
},
);
registerServiceExtension(
name: 'didSendFirstFrameEvent',
callback: (_) async {
return <String, dynamic>{
'enabled': _needToReportFirstFrame ? 'false' : 'true'
};
},
);
}
assert(() {

15
packages/flutter/test/foundation/service_extensions_test.dart
View File

@ -104,7 +104,20 @@ void main() {
test('Service extensions - pretest', () async {
binding = TestServiceExtensionsBinding();
expect(binding.frameScheduled, isTrue);
// We need to test this service extension here because the result is true
// after the first binding.doFrame() call.
Map<String, dynamic> firstFrameResult;
expect(binding.debugDidSendFirstFrameEvent, isFalse);
firstFrameResult = await binding.testExtension('didSendFirstFrameEvent', <String, String>{});
expect(firstFrameResult, <String, String>{ 'enabled': 'false' });
await binding.doFrame(); // initial frame scheduled by creating the binding
expect(binding.debugDidSendFirstFrameEvent, isTrue);
firstFrameResult = await binding.testExtension('didSendFirstFrameEvent', <String, String>{});
expect(firstFrameResult, <String, String>{ 'enabled': 'true' });
expect(binding.frameScheduled, isFalse);
expect(debugPrint, equals(debugPrintThrottled));
@ -548,7 +561,7 @@ void main() {
// If you add a service extension... TEST IT! :-)
// ...then increment this number.
expect(binding.extensions.length, 24 + widgetInspectorExtensionCount);
expect(binding.extensions.length, 25 + widgetInspectorExtensionCount);
expect(console, isEmpty);
debugPrint = debugPrintThrottled;