From 5126dfe55ebf3c7088ae16928ba5f1a01ac8f633 Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Wed, 11 Aug 2021 11:00:57 -0700 Subject: [PATCH] Python 3 compatibility fix for running Java tests using run_tests.py (flutter/engine#27970) (Note that LUCI is currently still running this script using Python 2) --- engine/src/flutter/testing/run_tests.py | 1 + 1 file changed, 1 insertion(+) diff --git a/engine/src/flutter/testing/run_tests.py b/engine/src/flutter/testing/run_tests.py index 0202072feba..7d78c9cb177 100755 --- a/engine/src/flutter/testing/run_tests.py +++ b/engine/src/flutter/testing/run_tests.py @@ -321,6 +321,7 @@ def AssertExpectedJavaVersion(): EXPECTED_VERSION = '1.8' # `java -version` is output to stderr. https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4380614 version_output = subprocess.check_output(['java', '-version'], stderr=subprocess.STDOUT) + version_output = version_output.decode('utf-8') match = bool(re.compile('version "%s' % EXPECTED_VERSION).search(version_output)) message = "JUnit tests need to be run with Java %s. Check the `java -version` on your PATH." % EXPECTED_VERSION assert match, message